Skip to content

feat: NCAAM eliminated player tracking + fix Wk NaN - #36

Merged
lbowsher merged 1 commit into
mainfrom
lb/league-home-update
Mar 22, 2026
Merged

lbowsher merged 1 commit into
mainfrom
lb/league-home-update

Conversation

@lbowsher

Copy link
Copy Markdown
Owner

Summary

  • Fix "Wk NaN" bug on league home page for NCAAM Best Ball leagues (caused by null week_number in game_stats)
  • Add eliminated column to players table (Supabase migration applied) for tracking knocked-out NCAA tournament teams
  • League home page: Show "X/Y active" player count per team for NCAAM leagues, with red highlight when 0 active
  • Team page: Show "X/Y players active" summary, "Eliminated" badge on knocked-out players, and dimmed (opacity) styling
  • Week labels: Use "G" prefix for non-NFL leagues (matching team page convention) instead of "Wk"
  • CLAUDE.md: Updated with shadcn/ui component conventions and auth best practices

Test plan

  • Visit an NCAAM Best Ball league page — verify no "Wk NaN" columns appear
  • Verify active player counts show on each team card (currently all should show X/X since no players are eliminated yet)
  • Visit an NCAAM team page — verify "X/Y players active" summary in score card
  • Set a player's eliminated to true in DB and verify: dimmed card, "Eliminated" badge, updated counts on both pages
  • Verify NFL leagues are unaffected (no active player counts, "Wk" prefix preserved)

🤖 Generated with Claude Code

… bug

- Add `eliminated` boolean column to players table (migration applied)
- Show active/total player counts on league home page for NCAAM teams
- Show eliminated badge and dimmed styling on team page player cards
- Fix "Wk NaN" display caused by null week_numbers in NCAAM game_stats
- Use "G" prefix instead of "Wk" for non-NFL league week labels
- Update CLAUDE.md with shadcn/ui conventions and auth patterns

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@vercel

vercel Bot commented Mar 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fanteasy Ready Ready Preview, Comment Mar 22, 2026 11:40pm

@lbowsher
lbowsher merged commit c78d3f0 into main Mar 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant