Skip to content

Fix urlscan pagination with json.Number sort values #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Imkznan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix urlscan pagination with json.Number sort values #173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions pkg/providers/urlscan/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ package urlscan

import (
"strings"
"fmt"
jsoniter "github.com/json-iterator/go"
)

var _BaseURL = "https://urlscan.io/"
Expand All @@ -25,12 +27,18 @@ type archivedPage struct {
}

func parseSort(sort []interface{}) string {
var sortParam []string
for _, t := range sort {
switch t.(type) {
case string:
sortParam = append(sortParam, t.(string))
}
}
return strings.Join(sortParam, ",")
var sortParam []string

for _, t := range sort {
switch v := t.(type) {
case string:
sortParam = append(sortParam, v)
case jsoniter.Number:
sortParam = append(sortParam, v.String())
default:
sortParam = append(sortParam, fmt.Sprint(v))
}
}

return strings.Join(sortParam, ",")
}