Conversation
- Added BatchOrganizeDialog component for selecting and moving pages between collections. - Introduced BatchOrganizeSetting component to filter and initiate batch moves. - Created BatchOrganizeController to handle API requests for filtering and moving pages. - Developed BatchOrganizeService to manage business logic for batch operations. - Implemented DTOs for batch filtering and moving requests/responses. - Enhanced PageRepository with batch update methods for collection management. - Updated PageService to handle library save status changes and timestamps. - Added pagination and selection features for improved user experience in batch operations.
…ith tooltip support
lcomplete
changed the title
🤖 Augment PR SummarySummary: This PR prepares the v0.5.5 release by adding batch organizing tools for the library, improving timestamp UX, and refining export/file naming. Changes:
Technical Notes: Batch operations support pagination + “select all” semantics, and backend move logic uses bulk updates (CriteriaUpdate / repository update queries) with optional collected-time remapping. 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| public BatchFilterResult filterPages(BatchFilterQuery query) { | ||
| Specification<Page> spec = buildSpecification(query); | ||
| int page = query.getPage() != null ? query.getPage() : 0; | ||
| int size = query.getSize() != null ? query.getSize() : DEFAULT_PAGE_SIZE; |
There was a problem hiding this comment.
filterPages() trusts query.getPage()/query.getSize(); if size <= 0 (or page < 0) this can trigger division-by-zero / PageRequest.of(...) exceptions and return 500s. Consider validating/clamping page/size (and query itself) before building the PageRequest.
🤖 Was this useful? React with 👍 or 👎
| } | ||
|
|
||
| private BatchMoveResult batchMoveByFilter(BatchMoveRequest request) { | ||
| BatchFilterQuery query = request.getFilterQuery(); |
There was a problem hiding this comment.
In batchMoveByFilter, request.getFilterQuery() can be null (malformed client / direct API call), which would NPE in buildSpecification(query). Consider rejecting the request when selectAll is true but filterQuery is missing.
🤖 Was this useful? React with 👍 or 👎
| .predicate(StringUtils.isNotBlank(query.getAuthor()), buildAuthorSpec(query.getAuthor())) | ||
| // Date range filter (always use createdAt) | ||
| .ge(StringUtils.isNotBlank(query.getStartDate()), "createdAt", convertDateToInstant(query.getStartDate(), 0)) | ||
| .lt(StringUtils.isNotBlank(query.getEndDate()), "createdAt", convertDateToInstant(query.getEndDate(), 1)); |
There was a problem hiding this comment.
The date predicates call convertDateToInstant(...), which returns null on parse failure; the underlying GeSpecification/LtSpecification don’t handle null compares and will throw at runtime. Consider only adding the createdAt bounds when parsing succeeds (or validate startDate/endDate upfront).
🤖 Was this useful? React with 👍 or 👎
| const data = await filterPages({ ...filterQuery, page: currentPage, size: PAGE_SIZE }); | ||
| setResult(data); | ||
| } catch (error) { | ||
| console.error("Failed to load pages:", error); |
There was a problem hiding this comment.
When filterPages(...) fails, the dialog only console.errors; from the UI it will look like an empty result set with no explanation. Consider surfacing the failure via enqueueSnackbar(...) (and/or clearing result) so users know the load failed.
🤖 Was this useful? React with 👍 or 👎
|
|
||
| /** | ||
| * How to set the collectedAt timestamp. | ||
| * Values: KEEP (keep original), UPDATE_NOW (set to current time), |
There was a problem hiding this comment.
BatchMoveRequest.collectedAtMode Javadoc lists UPDATE_NOW / field-name modes, but the implementation in BatchOrganizeService currently checks for USE_PUBLISH_TIME. Consider updating the comment to match the supported values to avoid API-contract confusion.
🤖 Was this useful? React with 👍 or 👎
…ling and pagination validation
1 participant
What's Changed
New Features
Commits
Full Changelog: v0.5.4...dev