Fixes in OEP/CPF Downloaders#6
Open
stefanlinden wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for the package, I have found the propagator to be very useful.
However, as also stated in issue #5, the downloaders are potentially powerful but broken at the moment. This PR fixes these issues to get in line with changes due to mainly CCDIS switching to CPF v2.
The changes are as follows:
requestswas missing and has been added. It has been added with a version wildcard though, but it should be fine with at least all versions from the last couple of years.astropyseems to download the EOP automatically anyway when it is not set, so the downloader may be superfluous?