Skip to content

cmd hint#62

Open
proteus1121 wants to merge 2 commits into
mainfrom
cmd-hint
Open

cmd hint#62
proteus1121 wants to merge 2 commits into
mainfrom
cmd-hint

Conversation

@proteus1121

Copy link
Copy Markdown
Collaborator

I add cmd hint in chart details
image

TODO: change http://localhost:8080/ to gateway url

@proteus1121 proteus1121 requested a review from leafchild0 May 6, 2022 10:53
@sonarqubecloud

sonarqubecloud Bot commented May 6, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Comment thread ui/src/components/ChartsDetails.vue Outdated
border-radius: 5px 5px 0 0;
position: relative;
}
.terminal .top {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a scss you don't need to use multiple selectors, just put everything inside .terminal selected and replace .terminal inside with '&', i.e. '& .top'

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 7c4c8ef

text-align: center;
font-size: 15px;
}
.red { background: #EC6A5F; border-color: #D04E42; }

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use buefy colors here? It's easy to do

@proteus1121 proteus1121 May 16, 2022

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean setup these colors in Apps.scss? I guess it will be used only here, it's just colors of fake terminal buttons

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, use buefy colors instead of defining new ones. https://bulma.io/documentation/customize/variables/. In your example, you can give a specific CSS class and get same results.
This is minor, of course.

Comment thread ui/src/views/Chart.vue Outdated
this.$toastr.e('Something went wrong while getting tags');
}).finally(() => this.loading = false);

api.getCurrentUser().then(response => {

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, username is already known, you can just get it from Vuex, look for 'mapGetters' keyword. There is no need to fetch user on every view

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 7c4c8ef

@proteus1121 proteus1121 requested a review from leafchild0 May 16, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants