Skip to content

fix: added asserts for total_num_variables >= point.len() check. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomWambsgans merged 1 commit into from
May 1, 2026
Merged

fix: added asserts for total_num_variables >= point.len() check. #208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion crates/whir/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ pub struct SparseStatement<EF> {

impl<EF> SparseStatement<EF> {
pub fn new(total_num_variables: usize, point: MultilinearPoint<EF>, values: Vec<SparseValue<EF>>) -> Self {
assert!(
total_num_variables >= point.len(),
"total_num_variables ({}) must be >= point.len() ({})",
total_num_variables,
point.len()
);
Self {
total_num_variables,
point,
Expand All @@ -47,6 +53,12 @@ impl<EF> SparseStatement<EF> {
}

pub fn new_next(total_num_variables: usize, point: MultilinearPoint<EF>, values: Vec<SparseValue<EF>>) -> Self {
assert!(
total_num_variables >= point.len(),
"total_num_variables ({}) must be >= point.len() ({})",
total_num_variables,
point.len()
);
Self {
total_num_variables,
point,
Expand Down Expand Up @@ -74,7 +86,9 @@ impl<EF> SparseStatement<EF> {
}

pub fn selector_num_variables(&self) -> usize {
self.total_num_variables - self.inner_num_variables()
self.total_num_variables
.checked_sub(self.inner_num_variables())
.expect("invariant violated: total_num_variables < point.len()")
}

pub fn inner_num_variables(&self) -> usize {
Expand Down
Loading