Python verifier#236
Merged
Merged
Conversation
Reverts the temporary single-threaded `find` introduced for deterministic debugging during the Python verifier port. With the bug found (sorted dict iteration in `stacked_pcs_global_statements`) the determinism aid is no longer needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Merge `TableInfo` and `TableMeta` into a single dataclass. - Drop `BusData`, `Bus.data`, `Bus.selector`, `Bus.direction_flag` — only `bus_direction` is ever read by the verifier; flatten it onto `TableMeta`. - Drop the `register_air_evaluator` decorator + global registry; replace with a direct dispatch table in `air_constraint_eval`. - Collapse per-table helpers (`_max_air_constraints`, `_table_degree_air`, `_table_down_column_indexes`, `_table_n_down_columns`) into one `_TABLE_SPECS` dict keyed by table name. - Replace ad-hoc lazy-init globals (`_WHIR_CONFIGS`, `_POSEIDON1_CONSTS`, `_load_whir_configs`, `_load_poseidon1_constants`, `_p1c`) with `functools.cache`d helpers. - Drop unused helpers: `poseidon16_permute`, `_from_int`, `_next_pow_two`, `whir_num_variables_at_round`, `_load_test_vector`, `EF.from_basis_coefficients`. - Trim `AirStageResult` to the three fields actually consumed downstream. - Strip "Port of X" / "Mirror of X" boilerplate from ~36 docstrings. - Condense `# ─── Section ───` banners to single lines. - Fold `test_zkvm.py` loader into `verifier.py:main()`. 3010 → 2742 lines, all four prior checks still pass (rec-aggregation proof verifies end-to-end). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ode / memory / poseidon / extension_op interractions
# Conflicts: # crates/backend/air/src/symbolic.rs # crates/lean_compiler/src/instruction_encoder.rs # crates/lean_prover/src/prove_execution.rs # crates/lean_prover/src/verify_execution.rs # crates/lean_vm/src/core/constants.rs # crates/lean_vm/src/tables/execution/air.rs # crates/lean_vm/src/tables/execution/mod.rs # crates/lean_vm/src/tables/extension_op/air.rs # crates/lean_vm/src/tables/extension_op/exec.rs # crates/lean_vm/src/tables/extension_op/mod.rs # crates/lean_vm/src/tables/mod.rs # crates/lean_vm/src/tables/poseidon_16/mod.rs # crates/lean_vm/src/tables/table_enum.rs # crates/lean_vm/src/tables/table_trait.rs # crates/lean_vm/src/tables/utils.rs # crates/rec_aggregation/src/compilation.rs # crates/rec_aggregation/zkdsl_implem/recursion.py # crates/sub_protocols/src/logup.rs # crates/sub_protocols/tests/soundness_logup.rs # crates/utils/src/multilinear.rs
TomWambsgans
added a commit
that referenced
this pull request
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.