Conversation
markusdemedeiros
marked this pull request as ready for review
August 10, 2026 22:33
Collaborator
Author
|
(@lzy0505 You could also review this too if you have time) |
Kaptch
reviewed
Aug 11, 2026
| scoped instance : COFE ℝ := COFE.ofDiscrete ℝ | ||
| scoped instance : OFE.Discrete ℝ := ⟨fun h => h⟩ | ||
|
|
||
| /-- info: CommMonoidLike.instUCMRA -/ |
Collaborator
There was a problem hiding this comment.
Are these intended to be left here? Would you mind if I remove/move it to test file?
Collaborator
Author
There was a problem hiding this comment.
Sure, go for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #267 plus
bi/lib/mono_Z.v, and adds some extra stuff to IrisMathThis PR generally tidies up and completes the numbers CMRA's. It provides (scoped) instances for three classes of commutative monoids which cover every variant in Iris-Rocq. Cameras that use nonstandard
Addinstances are newtyped to avoid leaking the wrong instances.I'll note that in doing this I found what I believe to be dead code in Iris-Rocq as well as missing instances. A win for generalization!
I like having a version that works for general commutative monoids because there are examples abound in mathlib, and I'd prefer to not copy-paste this for every numerical type. I presume that copy-paste was probably how Iris-Rocq ended up with dead instances.
Checklist
authorssection of any appropriate filesGenerative AI Guidelines
AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.
havestatements that do not aid readability or code reuse should be inlined.In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.