Skip to content

feat: Intial annotations for HeapLang - #605

Merged
lzy0505 merged 3 commits into
masterfrom
heap-lang-easy
Aug 12, 2026
Merged

feat: Intial annotations for HeapLang#605
lzy0505 merged 3 commits into
masterfrom
heap-lang-easy

Conversation

@markusdemedeiros

@markusdemedeiros markusdemedeiros commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Description

HeapLang is actually around 33% complete. This PR adds in those annotations.

Modulo any mistakes, I think all of the theorems are pointing to the right place. However some might warrant a closer look, since I don't really understand them fully.

  • wp_cmpXchg_fail/suc are stated differently to Rocq. Probably not a big deal?
  • wp_alloc does not return a meta_token, it should
  • tac_wp_alloc is different, the tac* lemmas I could not really evaluate the correctness of
  • heap_adequacy is a little different than the Rocq version because it doesn't start with an invariant. Intentional?

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros
markusdemedeiros marked this pull request as ready for review August 12, 2026 00:16
@lzy0505
lzy0505 merged commit 676d1fd into master Aug 12, 2026
5 checks passed
@lzy0505
lzy0505 deleted the heap-lang-easy branch August 12, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants