Skip to content

Fix: handle local Rocq name collisions in check-porting.py - #622

Merged
lzy0505 merged 1 commit into
leanprover-community:masterfrom
lzy0505:zliu/fix-porting-name-collusion
Aug 12, 2026
Merged

Fix: handle local Rocq name collisions in check-porting.py#622
lzy0505 merged 1 commit into
leanprover-community:masterfrom
lzy0505:zliu/fix-porting-name-collusion

Conversation

@lzy0505

@lzy0505 lzy0505 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Add file names as prefix to resolve collisions.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@lzy0505
lzy0505 merged commit 38a0be2 into leanprover-community:master Aug 12, 2026
5 checks passed
@lzy0505
lzy0505 deleted the zliu/fix-porting-name-collusion branch August 12, 2026 08:53
@alvinylt

Copy link
Copy Markdown
Contributor

@lzy0505 There are two items named persistently_absorbing in Iris-Rocq: one as a lemma in bi/interface.v and another as an instance of Absorbing in bi/derived_laws.v.

It shows up only once on the porting website. Does this fix resolve this issue?

@lzy0505

lzy0505 commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

Good spot. No I don't think so. I will fix it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants