feat: remaining type classes and instances for embedding - #624
Open
alvinylt wants to merge 19 commits into
Open
Conversation
MackieLoeffel
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! It looks mostly good to me. I just added some minor comments.
alvinylt
commented
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ports all remaining items in
InstanceEmbedding.lean,ClassesMake.leanandInstancesMake.leanunder theProofModedirectory.Most of these instances are straightforward as they are identical to those in Iris-Rocq. Instances of
FromModalandIntoWandare trickier as they involve various priorities and backtracking. These are tested inTests/Embedding.lean(commit 2d9c9b5). Instances that involve Lean-specific features (e.g.InOut,WandMode) are also tested.Other Changes
/- ... -/) versus documentation (/-- ... -/and/-! ... -/) so that they are not unintentionally associated with the theorem/definition/instance below it.$and<|.rocq_ignoreannotations for several items inModalities.lean.Checklist
authorssection of any appropriate files