Skip to content

feat: remaining type classes and instances for embedding - #624

Open
alvinylt wants to merge 19 commits into
leanprover-community:masterfrom
ISTA-PLV:InstancesEmbedding
Open

feat: remaining type classes and instances for embedding#624
alvinylt wants to merge 19 commits into
leanprover-community:masterfrom
ISTA-PLV:InstancesEmbedding

Conversation

@alvinylt

@alvinylt alvinylt commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Description

Ports all remaining items in InstanceEmbedding.lean, ClassesMake.lean and InstancesMake.lean under the ProofMode directory.

Most of these instances are straightforward as they are identical to those in Iris-Rocq. Instances of FromModal and IntoWand are trickier as they involve various priorities and backtracking. These are tested in Tests/Embedding.lean (commit 2d9c9b5). Instances that involve Lean-specific features (e.g. InOut, WandMode) are also tested.

Other Changes

  • Minor code style improvements
    • Fixes usage of comments (/- ... -/) versus documentation (/-- ... -/ and /-! ... -/) so that they are not unintentionally associated with the theorem/definition/instance below it.
    • Indentation according to the conventions.
    • Remove unnecessary uses of $ and <|.
    • Commits 977b184 and 2823cc3
  • Adds rocq_ignore annotations for several items in Modalities.lean.

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

@MackieLoeffel MackieLoeffel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks mostly good to me. I just added some minor comments.

Comment thread Iris/Iris/ProofMode/Classes.lean Outdated
Comment thread Iris/Iris/ProofMode/InstancesEmbedding.lean Outdated
Comment thread Iris/Iris/ProofMode/InstancesEmbedding.lean Outdated
Comment thread Iris/IrisTest/Embedding.lean
Comment thread Iris/IrisTest/Embedding.lean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port proofmode/class_instances_embedding.v Port proofmode/class_instances_make.v Port proofmode/classes_make.v

2 participants