Skip to content

Fix: real word decorators are more complicated #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ppotapov-aws merged 1 commit into from
Jan 13, 2026
Merged

Fix: real word decorators are more complicated #569

ppotapov-aws merged 1 commit into from
Jan 13, 2026

Conversation

@ppotapov-aws
Copy link
Collaborator

@ppotapov-aws ppotapov-aws commented Jan 13, 2026

Fixes a few things:

  • decorator can be producing a class instead of a function
  • decorator can be a ref to func not a just a func

govereau
govereau approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@govereau govereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, check out the wrapped Python thing if you get a chance.

@ppotapov-aws ppotapov-aws force-pushed the ppotapov/fix_decotrator_unwrapping branch from 6ce60c8 to 9b8ef7f Compare January 13, 2026 21:41
@ppotapov-aws ppotapov-aws merged commit 5579595 into main Jan 13, 2026
6 checks passed
@ppotapov-aws ppotapov-aws deleted the ppotapov/fix_decotrator_unwrapping branch January 13, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@govereau govereau govereau approved these changes

@seanmcl seanmcl Awaiting requested review from seanmcl seanmcl is a code owner

@jtristan jtristan Awaiting requested review from jtristan jtristan is a code owner

@joonwonc joonwonc Awaiting requested review from joonwonc joonwonc is a code owner

@waahm7 waahm7 Awaiting requested review from waahm7 waahm7 is a code owner

@jiancheng-aws jiancheng-aws Awaiting requested review from jiancheng-aws jiancheng-aws is a code owner

@yongweiy yongweiy Awaiting requested review from yongweiy yongweiy is a code owner

@kerrijoe-aws kerrijoe-aws Awaiting requested review from kerrijoe-aws kerrijoe-aws is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ppotapov-aws @govereau