Repository navigation
Fix/tools - #142
Merged
Merged
Fix/tools#142
Conversation
ratheron
approved these changes
Sep 24, 2026
ratheron
left a comment
ratheron
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fixes!
Please update the gif according to the comment and update the lock file (rebase from main).
Collaborator
There was a problem hiding this comment.
Why not "by topic"? Less steps to show
ratheron
reviewed
Sep 26, 2026
Collaborator
There was a problem hiding this comment.
Does this work, or do you also need to set the QoS?
Collaborator
There was a problem hiding this comment.
Also, could you please make this a jpg? They are way smaller and we don't want to inflate the size of the repo if not necessary
Collaborator
|
Unfortunately, the lock file still raises a merge conflict. Please resolve |
… to frame publisher
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes following problems:
nominal_frame_publisherout of the mocap activation command. This also fixes the estimator "occluded" issue. I think it was because the two processes were spawned in the same terminal instancenominal_frame_publisherso you can run the node with different configs/deployto explain the usage of the tool