Skip to content

Bump bollard + use proper Ledger Docker container - #13

Merged
yogh333 merged 5 commits into
mainfrom
y333/update_sim
Jan 14, 2026
Merged

Bump bollard + use proper Ledger Docker container#13
yogh333 merged 5 commits into
mainfrom
y333/update_sim

Conversation

@yogh333

@yogh333 yogh333 commented Nov 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@yogh333
yogh333 marked this pull request as ready for review November 7, 2025 16:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the simulator to support three new Ledger device models (Stax, Flex, and NanoGen5), migrates from bollard 0.18 to 0.19.4, and makes the display mode optional. The changes include API updates to use builder patterns, switching to a new Docker image, and adding X11 forwarding for graphical display support.

Key Changes:

  • Added support for three new Ledger models: Stax, Flex, and NanoGen5
  • Migrated bollard library from 0.18 to 0.19.4 with corresponding API changes to use builder patterns
  • Changed display mode from required with default to optional, and modified default http_port from 5000 to 5001

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
sim/src/lib.rs Added three new Model variants (Stax, Flex, NanoGen5), changed display field to Option, updated default http_port, and adjusted args() method to handle optional display
sim/src/drivers/docker.rs Updated imports to use new bollard builder APIs, changed Docker image to ledger-app-dev-tools, modified container naming to use model instead of port, added X11 forwarding support, and applied builder patterns throughout
sim/Cargo.toml Updated bollard dependency from 0.18 to 0.19.4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread sim/src/drivers/docker.rs Outdated
Comment thread sim/src/drivers/docker.rs Outdated
Comment thread sim/src/drivers/docker.rs Outdated
Comment thread sim/src/lib.rs
Comment thread sim/src/drivers/docker.rs Outdated
@yogh333
yogh333 merged commit b261854 into main Jan 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants