Bump bollard + use proper Ledger Docker container - #13
Merged
Conversation
yogh333
marked this pull request as ready for review
November 7, 2025 16:00
yogh333
force-pushed
the
y333/update_sim
branch
from
November 10, 2025 09:02
4faf395 to
2d86ec6
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the simulator to support three new Ledger device models (Stax, Flex, and NanoGen5), migrates from bollard 0.18 to 0.19.4, and makes the display mode optional. The changes include API updates to use builder patterns, switching to a new Docker image, and adding X11 forwarding for graphical display support.
Key Changes:
- Added support for three new Ledger models: Stax, Flex, and NanoGen5
- Migrated bollard library from 0.18 to 0.19.4 with corresponding API changes to use builder patterns
- Changed display mode from required with default to optional, and modified default http_port from 5000 to 5001
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| sim/src/lib.rs | Added three new Model variants (Stax, Flex, NanoGen5), changed display field to Option, updated default http_port, and adjusted args() method to handle optional display |
| sim/src/drivers/docker.rs | Updated imports to use new bollard builder APIs, changed Docker image to ledger-app-dev-tools, modified container naming to use model instead of port, added X11 forwarding support, and applied builder patterns throughout |
| sim/Cargo.toml | Updated bollard dependency from 0.18 to 0.19.4 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.