list applications installed on device - #7
Merged
Conversation
Collaborator
Contributor
Author
|
You are right, pushed my PR too soon, will do the job |
Contributor
Author
|
Done ! |
yogh333
changed the title
yogh333
force-pushed
the
feat/listDeviceApps
branch
from
November 7, 2025 11:03
f8cd06f to
816e357
Compare
yogh333
force-pushed
the
feat/listDeviceApps
branch
from
November 7, 2025 11:35
2bc20b7 to
d9034e5
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to list installed applications on Ledger devices by introducing new APDU commands (AppListStartReq and AppListNextReq) and a high-level app_list method on the Device trait. The implementation also includes a CLI command to display the list of installed apps and refactors the Filters enum to use derive macros for the Default implementation.
- New APDU commands for listing apps with pagination support
- High-level
app_list()method on Device trait - CLI command
ListAppto display installed applications
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| proto/src/apdus/mod.rs | Exports new app_list module and its types |
| proto/src/apdus/app_list.rs | Defines app list APDU commands and app data decoding |
| lib/src/device.rs | Implements app_list method on Device trait |
| lib/src/lib.rs | Refactors Filters enum to use derive Default |
| lib/src/transport/usb.rs | Simplifies error handling with ? operator |
| cli/src/main.rs | Adds ListApp command and unused AppInfo struct |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
list application installed on device using unsecure instructions (requires user's consent).