[OU-ADD] iap: backfill service_id from legacy service_name#37
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
dnplkndll
force-pushed
the
19.0-mig-iap-pre-migration
branch
from
212e9f0 to
1f8b453
Compare
dnplkndll
force-pushed
the
19.0-mig-iap-pre-migration
branch
from
1f8b453 to
b01bcfa
Compare
dnplkndll
force-pushed
the
19.0-mig-iap-pre-migration
branch
3 times, most recently
from
6fa0854 to
0c928dd
Compare
dnplkndll
force-pushed
the
19.0-mig-iap-pre-migration
branch
2 times, most recently
from
ded2721 to
b9fb2a8
Compare
Upgrade-scarred DBs keep the preserved legacy column with service_id NULL despite 19.0's required=True — warns at every schema sync until relinked.
dnplkndll
force-pushed
the
19.0-mig-iap-pre-migration
branch
from
b9fb2a8 to
e1ad1d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backfills
iap.account.service_idfrom the preservedopenupgrade_legacy_*_service_namecolumn — the real-production shape found in the Ledo prod dry-run (gotcha #11): DBs that lived through pre-18.0 upgrades carry the legacy column and rows whose service link was lost.Rebased 2026-07-13 on top of upstream OCA/OpenUpgrade#5800 (which marked iap
Nothing to do | No DB layout changes.). That verdict is correct for the 18→19 hop on a pristine schema and incomplete for upgrade-scarred DBs — this PR's docsource hunk deliberately overrides it, andtests/data_iap_migration.pyrecreates the scar on the CI seed so the migration test itself executes the backfill (logged_queryshows the rows moved). On a DB without the legacy column the script is a guarded no-op.https://claude.ai/code/session_01MpdyzmGjVAYqAEqMYr3EnX