[19.0][FIX] ddmrp: retarget buffer move grouping to stock.reference#16
Open
dnplkndll wants to merge 1 commit into
Open
[19.0][FIX] ddmrp: retarget buffer move grouping to stock.reference#16dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
force-pushed
the
19.0-fix-stock-reference
branch
5 times, most recently
from
f871a16 to
11793e2
Compare
dnplkndll
force-pushed
the
19.0-fix-stock-reference
branch
3 times, most recently
from
a5ad033 to
8d9117b
Compare
The 19.0 migration renamed the group_id comodel from the removed procurement.group to stock.rule, leaving a "Procurement Group" picker that lists stock rules and a group_id procurement-values key that nothing consumes. Core 19 groups moves and pickings by stock.reference (values["reference_ids"] in stock.rule._get_stock_move_values, reference_ids in _search_picking_for_assignation_domain), so point the field there and emit reference_ids to restore the grouping behavior.
dnplkndll
force-pushed
the
19.0-fix-stock-reference
branch
from
8d9117b to
c59b18f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #4 (one concern per PR). The 19.0 migration renamed the
group_idcomodel from the removedprocurement.grouptostock.rule, leaving a "Procurement Group" picker that lists stock rules and a deadgroup_idvalues key. Core 19 groups moves/pickings bystock.reference(values["reference_ids"]), so the field points there now and the values key is renamed; test pins the contract. Functional runboat walk planned before upstream filing.