[19.0][FIX] ddmrp: aggregate future actual demand in product UoM#6
Merged
Conversation
The 19.0 migration switched _calc_adu_future_demand from summing product_qty (product UoM) to product_uom_qty (move UoM). A confirmed future delivery of 5 Dozen then contributed 5 instead of 60 to the ADU, undersizing buffers for any non-unit secondary UoM. The past-demand path already aggregates in product UoM (quantity_product_uom).
dnplkndll
force-pushed
the
19.0-fix-adu-future-uom
branch
from
8122140 to
dc9f943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream-staging branch: exactly the future-ADU UoM fix + its regression test, isolated from #4 for separate upstream filing. Red-proof (same test, no fix, CI red): #5.