[DEMO] hr-expense trip suite — sales-rep budget + approvals walk#4
Open
dnplkndll wants to merge 78 commits into
Open
[DEMO] hr-expense trip suite — sales-rep budget + approvals walk#4dnplkndll wants to merge 78 commits into
dnplkndll wants to merge 78 commits into
Conversation
(cherry picked from commit 958f048)
(cherry picked from commit 1fb90c1)
(cherry picked from commit 3117aaf)
(cherry picked from commit 8af8d1d)
(cherry picked from commit 58e36ee)
(cherry picked from commit 288a719)
(cherry picked from commit e209ca1)
(cherry picked from commit cb26762)
(cherry picked from commit caf1f0b)
(cherry picked from commit 956f61c)
(cherry picked from commit dac1f33)
(cherry picked from commit e242daf)
Currently translated at 100.0% (6 of 6 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_payment/it/ (cherry picked from commit 4aee4df)
(cherry picked from commit 7069276)
(cherry picked from commit c797712)
(cherry picked from commit cd2e59b)
(cherry picked from commit 0cf4e03)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_payment/ (cherry picked from commit 57cb790)
(cherry picked from commit c71a6fa)
(cherry picked from commit 69560c7)
(cherry picked from commit 02e018f)
(cherry picked from commit c9932e4)
Related to odoo/odoo@2dc6b6c (cherry picked from commit 8692a69)
(cherry picked from commit 72ceb08)
(cherry picked from commit 6660847)
…thod (cherry picked from commit a82dace)
(cherry picked from commit df0b0b0)
(cherry picked from commit 6a3bf00)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_payment/ (cherry picked from commit fecb164)
Currently translated at 100.0% (5 of 5 strings) Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_payment Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_payment/it/ (cherry picked from commit 0b64eb0)
…ly on new clearing (cherry picked from commit fbbf303)
(cherry picked from commit 9728fd3)
(cherry picked from commit c9ad5bc)
(cherry picked from commit ee44183)
(cherry picked from commit 6f13bc8)
… clearing (cherry picked from commit 8d5a396)
(cherry picked from commit e6bc12d)
(cherry picked from commit c328cfc)
(cherry picked from commit 0004a0e)
Currently translated at 100.0% (57 of 57 strings) Translation: hr-expense-15.0/hr-expense-15.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-15-0/hr-expense-15-0-hr_expense_advance_clearing/it/ (cherry picked from commit 3a273f0)
Currently translated at 100.0% (56 of 56 strings) Translation: hr-expense-16.0/hr-expense-16.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-16-0/hr-expense-16-0-hr_expense_advance_clearing/it/ (cherry picked from commit 1d62501)
(cherry picked from commit b91cc90)
…company so that the correct property can be retrieved (cherry picked from commit 213cb2f)
Related to odoo/odoo@063e224 (cherry picked from commit e174e02)
(cherry picked from commit 32354d4)
(cherry picked from commit 9831b13)
(cherry picked from commit 4dcae4d)
…s might intervene. TT55529 (cherry picked from commit 4a89241)
Currently translated at 100.0% (56 of 56 strings) Translation: hr-expense-18.0/hr-expense-18.0-hr_expense_advance_clearing Translate-URL: https://translation.odoo-community.org/projects/hr-expense-18-0/hr-expense-18-0-hr_expense_advance_clearing/it/ (cherry picked from commit 533941a)
…patibility) Since some other modules can introduce other moves to the expense sheet, this refactor allow some compatibility between those modules without changing behavior on this module. (cherry picked from commit 2be9623)
hr.expense.sheet was removed in 19.0; retarget the payment register to hr.expense.
hr.expense.sheet removed in 19.0; retarget to hr.expense (+ hr.employee.base->hr.employee).
…19.0-demo-payment-trip
…ng' into 19.0-demo-advance-clearing-trip
…type) Bridge module (auto_install) depending on hr_expense_payment + hr_expense_trip. Adds a 'Pay Trip' action that registers a single payment over the trip's posted, unpaid expenses via the standard expense register-payment flow.
…totype) Bridge module (auto_install) depending on hr_expense_advance_clearing + hr_expense_trip. Adds a Trip Advance on the trip and an 'Apply Advance' action that clears the trip's regular expenses against it in one step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined eval branch stacking the optional Trip layer over base hr-expense so the whole story installs as one unit:
hr_expense_trip+advance_clearing(_trip)+payment(_trip).Purpose: evaluate the trip's value for a common SMB case — a sales rep whose trips need a budget (a prepaid advance) and approvals (the trip workflow), with expenses grouped and reimbursed once. The Trip is opt-in; the plain per-expense flow is unchanged when no trip is used.
Builds on the trip foundation (#1) and the two bridges (#2 payment, #3 advance). See
DEMO_trip_suite.mdfor the full base-vs-trip narrative. Eval on the runboat build (admin/admin).Sales-rep walk (captured on the runboat build)
Scenario: rep Riley Carter, a $2,000 prepaid travel advance, and a Q1 East Coast Sales Tour with three expenses (flight $480, hotel $640, client dinner $185), all managed and approved by the expense manager.
1 — Trip container. One record holds the whole tour: the prepaid advance (Trip Advance / Advance Remaining), the workflow status bar (Draft → Requested → Collect Receipts → Done), and every expense for the trip.
Apply Advanceclears the trip's expenses against the advance in one click.2 — Line-level linkage. Each expense line carries both its Trip and the Clearing Advance it was reconciled against — the chatter logs the advance link. This is the bridge wiring (
hr_expense_advance_clearing_trip) at the line level.3 — Base contrast. Without trips, the same expenses are loose lines in the flat firehose — no budget, no grouping, no single approval or reimbursement step. The Trip layer is what turns this list into the managed tour above.