Skip to content

Fix version generation when there is not git (like a tarball) #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leducp merged 1 commit into from
Jun 23, 2026
Merged

Fix version generation when there is not git (like a tarball) #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion cmake/version.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
# (build time): re-runs git and rewrites the header.
#
# With no git available (source tarball / conan-from-recipe) it falls back to
# 0.0.0 and "unknown" git fields.
# 0.0.0 and "unknown" git fields, unless -D KICKMSG_VERSION_OVERRIDE=X.Y.Z is
# passed (e.g. by a package recipe that knows the release version).

function(_kickmsg_compute_version src_dir)
set(_describe "unknown")
Expand Down Expand Up @@ -48,6 +49,20 @@ function(_kickmsg_compute_version src_dir)
endif()
endif()

# Explicit override (release tarball / packaging, where no .git exists).
if(KICKMSG_VERSION_OVERRIDE)
string(REGEX REPLACE "^v" "" _override "${KICKMSG_VERSION_OVERRIDE}")
if(_override MATCHES "^[0-9]+\\.[0-9]+\\.[0-9]+")
set(_ver "${_override}")
if(_describe STREQUAL "unknown")
set(_describe "v${_ver}")
endif()
if(_tag STREQUAL "")
set(_tag "v${_ver}")
endif()
endif()
endif()

if(_ver MATCHES "^([0-9]+)\\.([0-9]+)\\.([0-9]+)")
set(_maj "${CMAKE_MATCH_1}")
set(_min "${CMAKE_MATCH_2}")
Expand Down Expand Up @@ -98,6 +113,7 @@ add_custom_command(
COMMAND ${CMAKE_COMMAND}
-D KICKMSG_VERSION_SRC=${CMAKE_CURRENT_SOURCE_DIR}
-D KICKMSG_VERSION_OUT=${KICKMSG_VERSION_H}
-D KICKMSG_VERSION_OVERRIDE=${KICKMSG_VERSION_OVERRIDE}
-P "${CMAKE_CURRENT_SOURCE_DIR}/cmake/version.cmake"
DEPENDS ${_version_deps}
COMMENT "Regenerating kickmsg/version.h from git"
Expand Down
Loading