Skip to content

test: preserve iOS ASR failure phase diagnostics - #489

Merged
leehack merged 2 commits into
mainfrom
test/ipad-asr-phase-diagnostics
Sep 8, 2026
Merged

test: preserve iOS ASR failure phase diagnostics#489
leehack merged 2 commits into
mainfrom
test/ipad-asr-phase-diagnostics

Conversation

@leehack

@leehack leehack commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Scope

Closes #488.

Recover useful preserved iPad diagnostic work on current main. Qwen3-ASR failures now carry content-free setup/transcript/cancellation/microphone/reload/teardown phase evidence and validated short SHA-256 identifiers. Shared row recording preserves other-row behavior; cleanup cannot replace the primary failure or phase. Invalid setup metadata is omitted rather than logged. The original dirty worktree is untouched.

Runtime behavior, acceptance assertions, microphone requirements, dependency pins, release policy, and public APIs are unchanged. No model or physical-device run is claimed.

Current-main refresh

Normal merge commit da8ac9b integrates base 3d9e377 after recovery #491 completed exact-main CI successfully. No rebase or force push. The PR diff remains exactly three harness/test files.

Validation

  • Actual local macOS Flutter 3.47.1 support test execution: PASS, all 123 physical_ios_speech_e2e_support_test.dart cases. The previous Apple hook blocker is fixed on main; no bypass is used.
  • Dart 3.13.1 touched-file analyzer and canonical format: PASS. git diff --check: PASS.
  • Behavioral regressions cover every phase, invalid digests, nested cleanup, preserved failure identity, row mismatch, and unchanged other-row results; static wiring complements behavior tests.
  • Fresh independent Astra exact-head QA at da8ac9b against 3d9e377: PASS, no blocking findings. Reviewed actual phase/cleanup/recording call sites and bounded privacy serialization. No further worthwhile cleanup or optimization identified.
  • Current-head hosted CI: 13/13 populated checks SUCCESS, including Linux coverage/aggregate, native macOS/Windows, Chrome, docs/lint, Web Chat Contract real worker/GGUF smoke, companions, parity, advisory and preview. CI run: https://github.com/leehack/llamadart/actions/runs/34232011375 . Hosted macOS also passed the explicit fresh/warm/add/remove Flutter cache-transition integration.
  • Final refresh: CLEAN/MERGEABLE, clean local/remote exact head, 0 behind / 2 ahead; zero unresolved review threads. Technically ready, deliberately remains draft pending maintainer decision.
  • Current GraphQL review threads: 0 total / 0 unresolved. No automated approving review is claimed.

Boundaries

No mark-ready, merge, publication, workflow dispatch, pin change, or physical device action. No known PR-caused P1 regression. This remains draft for maintainer consideration. The original dirty iPad worktree and preserved local changes are untouched.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Chat app preview removed for leehack/llamadart-chat-pr-489.

@leehack
leehack marked this pull request as ready for review September 8, 2026 14:32
@leehack
leehack merged commit ecaa123 into main Sep 8, 2026
14 checks passed
@leehack
leehack deleted the test/ipad-asr-phase-diagnostics branch September 8, 2026 14:34
@leehack leehack mentioned this pull request Sep 9, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve physical iOS Qwen3-ASR phase diagnostics

1 participant