Log HTTP access and JSON-RPC error responses - #350
Open
venti1112 wants to merge 1 commit into
Open
Conversation
Add structured access logging and error-response logging. _handleRequest now captures the remote address, calls a new _handleRequestCore, and logs method, path, status, reason, MCP session id, and remote IP in a finally block (guarded to never break request handling). Also log JSON-RPC error responses at warn level with HTTP status, MCP error code, optional request id, and message. These changes improve observability while preserving request flow and safety.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
=======================================
Coverage 85.86% 85.87%
=======================================
Files 82 82
Lines 20514 20529 +15
=======================================
+ Hits 17615 17629 +14
- Misses 2899 2900 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add structured access logging and error-response logging. _handleRequest now captures the remote address, calls a new _handleRequestCore, 和 logs method, path, status, reason, MCP session id, and remote IP in a finally block (guarded to never break request handling). Also log JSON-RPC error responses at warn level with HTTP status, MCP error code, optional request id, and message. These changes improve observability while preserving request flow and safety.