Buttons' visibility

[lcaprini]

Extend buttons' visibility to all available buttons with provider configuration and directive override

[jasny]

Improvement, but BC break

[lcaprini]

I restored all previous attributes to avoid backward compatibility.

[jasny]

Approved. Need to test before merge

[jasny]

@moesjarraf Can you pick up testing and merging this?

[moesjarraf]

I don't think a lot of the code in this PR is necessary. This angular module works based on mozilla/pdf.js. Which means that if they add new buttons, we will have to update the code aswell since you added an object property for every button. That object is not necessary, even for the default behaviour, because by default all the buttons are displayed anyway.

It would be best to just add a list of buttons to the readme, and through an attribute we can specify an array of id's that should be disabled/removed.

You don't have to check whether the id exists in an object, just do:

// psuedo code
var button = document.getElementById(key);

if (!button) {
  return;
}

// continue logic
... 

So add the following to the readme, as you put in the code:

buttons: {
  sidebarToggle : true,
  viewFind : true,
  previous : true,
  next : true,
  pageNumberLabel : true,
  pageNumber : true,
  numPages : true,
  zoomOut : true,
  zoomIn : true,
  scaleSelectContainer : true,
  presentationMode : true,
  openFile : true,
  print : true,
  download : true,
  viewBookmark : true,
  secondaryToolbarToggle : true
}

[jasny]

@lcaprini Can you please make the suggested change. Buttons should be visible unless they are configured not to be visible. This makes adding defaults for each button unnecessary.

don't worry about the dist conflict

[lcaprini]

@jasny @moesjarraf I removed default buttons list to accept all actual and future buttons.
Also I've updated demo with buttons configuration example