Prevent concurrent refresh operations from racing in EventManager#887
Draft
Copilot wants to merge 3 commits intocodex/update-error-handling-in-setuppublishersfrom
Draft
Prevent concurrent refresh operations from racing in EventManager#887Copilot wants to merge 3 commits intocodex/update-error-handling-in-setuppublishersfrom
Copilot wants to merge 3 commits intocodex/update-error-handling-in-setuppublishersfrom
Conversation
Co-authored-by: leits <12017826+leits@users.noreply.github.com>
Co-authored-by: leits <12017826+leits@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix last events loss on refresh errors
Prevent concurrent refresh operations from racing in EventManager
Jan 29, 2026
leits
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two issues in the EventManager refresh error handling introduced in PR #886: a race condition where concurrent refreshes could overwrite newer data with stale snapshots, and missing test coverage for the error fallback behavior.
Changes
maxPublishers: .max(1)to.flatMapoperator to serialize refresh operations and cancel in-flight refreshes when new ones triggershouldThrowOnFetch*) and call counters to enable testing fetch failuresRefreshErrorHandlingTests.test_eventsPreservedOnRefreshFailure()verifying calendars/events retain previous values when fetches failRace condition scenario (now prevented)
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.