Fix race condition in EventManager refresh error handling#895
Draft
Copilot wants to merge 2 commits intocodex/update-error-handling-in-setuppublishersfrom
Draft
Fix race condition in EventManager refresh error handling#895Copilot wants to merge 2 commits intocodex/update-error-handling-in-setuppublishersfrom
Copilot wants to merge 2 commits intocodex/update-error-handling-in-setuppublishersfrom
Conversation
Co-authored-by: leits <12017826+leits@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update handling of last events during refresh errors
Fix race condition in EventManager refresh error handling
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multiple refreshes fired concurrently, a failing refresh could overwrite newer values written by a succeeding one — because each Task captured a
currentsnapshot upfront, and the error handler blindly restored that stale state.Changes
EventManager.swift: On fetch failure, emitnilinstead of the stalecurrentsnapshot; add.compactMap { $0 }so the.sinkonly fires on success. Failed refreshes now leave published properties untouched entirely.FakeEventStore.swift: AddedshouldThrowflag to simulate fetch failures in tests.EventManagerTests.swift: Addedtest_eventsPreservedOnRefreshError— uses an inverted expectation to assert no$eventsupdate is published after a failed refresh.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.