This repository was archived by the owner on Jun 6, 2025. It is now read-only.
Added editor instance as onReady function parameter $evalAsync - #28
Open
JonnyFox wants to merge 1 commit into
Open
Added editor instance as onReady function parameter $evalAsync#28JonnyFox wants to merge 1 commit into
JonnyFox wants to merge 1 commit into
Conversation
JonnyFox
commented
Oct 24, 2015
JonnyFox
commented
- Refactor to $scope.$evalAsync (avoid setTimeout)
- Added editor instance as parameter of onReady function
- Refactored to $scope.$evalAsync
|
Hi, is this project still alive? Can somebody merge this PR? I need the same improvements in one of my projects. Thanks! |
Contributor
|
I'm reviewing it but note that tests are broken... |
|
@JonnyFox up for the unit tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.