Skip to content
This repository was archived by the owner on Jun 6, 2025. It is now read-only.

Pass CKEditor instance on ready callback - #46

Open
MicahFulton wants to merge 1 commit into
lemonde:masterfrom
MicahFulton:instance-onready
Open

Pass CKEditor instance on ready callback#46
MicahFulton wants to merge 1 commit into
lemonde:masterfrom
MicahFulton:instance-onready

Conversation

@MicahFulton

Copy link
Copy Markdown

This solves issue #37

  • Adds the ability to get the reference to the editor instance on ready().
  • Updates the angular model on the selection change and paste events.

…ready(). This also updates the angular model on the selection change and paste events.
@mckoon

mckoon commented Jun 27, 2016

Copy link
Copy Markdown

The ability to get the CKEditor instance in the provided ready callback seems like a good change. I would like to use this instead of my separate directive to get the instance.

Is this something that is likely to be merged?

Thanks!

iboshkov referenced this pull request in iboshkov/angular-ckeditor Oct 17, 2016
@JBustin JBustin self-assigned this Nov 2, 2016
Comment thread angular-ckeditor.js
controller.ready().then(function initialize() {
// Sync view on specific events.
['dataReady', 'change', 'blur', 'saveSnapshot'].forEach(function (event) {
['dataReady', 'change', 'blur', 'saveSnapshot', 'selectionChange', 'paste'].forEach(function (event) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why model should be sync on selectionChange event ?

@JBustin

JBustin commented Nov 2, 2016

Copy link
Copy Markdown

@mckoon
We prepare a release with many fixes. Could you remove the minification of this PR ?
Thx

@mckoon

mckoon commented Nov 2, 2016

Copy link
Copy Markdown

@JBustin - I think you mentioned me by mistake; this PR is from @MicahFulton not me.

Thanks

@coolduebtn

Copy link
Copy Markdown

when will the changes be merged on the master. I am waiting for this fix eagerly.

@JBustin

JBustin commented Nov 7, 2016

Copy link
Copy Markdown

@MicahFulton
We prepare a release with many fixes. Could you remove the minification of this PR ?
Thx

@coolduebtn

Copy link
Copy Markdown

@JBustin Can you please merge the changes on master asap. I need this change urgently or else I will have to create a separate directive just with this change..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants