refactor: Rename package from monext_payment to monext_flutter_sdk - #37
Merged
Conversation
…example The plugin's pubspec/iOS Package.swift name (monext_payment) didn't match the repo's checkout directory name, which Flutter's Swift Package Manager integration uses to compute the plugin's local package identity. This caused Xcode to fail with "unable to override package... doesn't match override's identity" when adding SPM integration. Renaming the package to match the (to be renamed) repo name fixes it at the source instead of requiring a directory-naming workaround in every consuming app and in CI. The example app is renamed to monext_example (pubspec name and UI/native identifiers only, folder stays `example/`) to no longer reference the old plugin name. Android package (io.lenra.monext_payment) is left unchanged since it isn't affected by this issue.
The GitHub repo is still named monext-flutter, so the default checkout path doesn't match the plugin's new pubspec/Package.swift name (monext_flutter_sdk), which reintroduces the SPM identity mismatch this rename was meant to fix. Force the checkout directory name until the repo itself is renamed to match.
taorepoara
changed the title
Files already live under the monext_flutter_sdk package and export
payment-domain symbols (MonextPaymentResult, MonextPaymentNotInitialized-
Exception, etc.), so the "_payment_" segment in their own file names was
redundant. Only file names change; the shared MethodChannel name
("monext_payment", used by the Android/iOS native sides too) is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the Flutter plugin package from
monext_paymenttomonext_flutter_sdkacross all source files, configuration files, and documentation. This aligns the package name with the repository name and simplifies the Swift Package Manager integration by eliminating the need for custom checkout paths.Key Changes
Package Naming: Renamed all references from
monext_paymenttomonext_flutter_sdkin:pubspec.yaml(main plugin and example app)CI/CD Simplification: Removed the custom checkout path (
path: monext_payment) from the macOS CI workflow since the repository name now matches the package name, eliminating the Swift Package Manager identity mismatch issueExample App Updates:
monext_payment_exampletomonext_exampleFile Reorganization: Reorganized iOS source files from
monext_payment/Sources/monext_payment/tomonext_flutter_sdk/Sources/monext_flutter_sdk/directory structureDocumentation: Updated all references in guides and README files to reflect the new package name
Notable Details
The CI workflow now relies on the default checkout path since the repository name (
monext_flutter_sdk) matches the package name, which satisfies Swift Package Manager's identity requirements without needing a custom path configuration.https://claude.ai/code/session_01EtxvB7XVMNDEoLJdX5PtqU