Fix torque sensor idle calibration and motor overrun#2
Open
bbeschea wants to merge 8 commits into
Open
Conversation
Updated torque sensor offset calculation to latest version.
Bugfix for overrun Conflicts: src/controller/motor.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the new calculation of torque sensor minimal value by Casainho
This is mandatory if the torque sensor value read on idle is below 100 units. With the current implementation you get torque sensor error on startup.
Also the new calibration is better than before, any torque unit above the min value engages the motor.
I installed a new sensor and I did the hardware calibration. The torque range is now 35-275. The behavior is completely different than before. It is possible to get 750w+ on hard press even on small assistance levels.
I also added the overrun fix made by Mbrusa.