Add option to await child process to avoid race conditions - #11
Open
njdancer wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found an issue with this plugin where occasionally, some of the outputs of these tasks were not yet available by the time the subsequent build step ran.
This seems to be a result of the way the child process is called. Vite will accept a promise as a return value and subsequently await the promise before proceeding. This update modifies the execute command to be async and await all of the child processes it creates. This is technically a breaking change as there may be some users that rely on the existing behaviour. For this reason, an
awaitoption has also been added so that this behaviour can be opted in to. I would consider making this the default at some point in the future however, as I think its what most users will want and expect.