fix: apply base_uri via withOptions() when custom client is injected - #16
Closed
lepresk wants to merge 1 commit into
Closed
fix: apply base_uri via withOptions() when custom client is injected#16lepresk wants to merge 1 commit into
lepresk wants to merge 1 commit into
Conversation
When useClient() was called before collection(), disbursement(), or create(), the base_uri setup was skipped entirely, causing Symfony to throw "Invalid URL: scheme is missing" on relative paths. Closes #10 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useClient()was called beforecollection(),disbursement(), orcreate(), thebase_urisetup block was skipped entirely (guarded byself::$client === null), causing Symfony to throwInvalid URL: scheme is missingon relative paths.elsebranch in all three methods that callswithOptions(['base_uri' => ...])on the existing client.Test plan
composer test)Invalid URL: scheme is missing🤖 Generated with Claude Code