fix: correct getPayee() and silent env fallback - #18
Closed
lepresk wants to merge 3 commits into
Closed
Conversation
When useClient() was called before collection(), disbursement(), or create(), the base_uri setup was skipped entirely, causing Symfony to throw "Invalid URL: scheme is missing" on relative paths. Closes #10 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Transaction::getPayee() was delegating to getPayer(); model now stores payer and payee separately so each getter reads the right data (#12) - AirtelDisbursementApi was casting amounts via intval(), silently truncating fractional values like 100.50 to 100 (#14) - MomoApi::getBaseUrl() was falling through to PRODUCTION_URL for any unknown environment string; now throws InvalidArgumentException (#15) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lepresk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed:
Transaction::getPayee()was callinggetPayer()(copy-paste error). The model now stores$payerand$payeeas separate fields;parse()maps them from the correct API keys.MomoApi::getBaseUrl()fell back toPRODUCTION_URLfor any unknown environment string. Now throwsInvalidArgumentExceptionfor values not in the list of known constants.Test plan
composer test)getPayee()returns correct beneficiary on a disbursement transaction'Sandbox'(wrong case) throws instead of routing to production🤖 Generated with Claude Code