fix: useClient() base_uri bypass, getPayee() wrong data, getBaseUrl() silent fallback - #19
Merged
Conversation
…tBaseUrl() silent fallback - useClient() followed by collection()/disbursement()/create() skipped the base_uri setup entirely; now applies withOptions() on the existing client - Transaction::getPayee() delegated to getPayer(); model now stores payer and payee separately so each getter reads the correct field - getBaseUrl() silently routed unknown environments to production; now throws InvalidArgumentException for unrecognized values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10, #12, #15
#10 —
useClient()followed bycollection()/disbursement()/create()skipped thebase_urisetup block entirely (guarded by$client === null), causing Symfony to throw Invalid URL: scheme is missing. Now applieswithOptions()on the existing client.#12 —
Transaction::getPayee()was delegating togetPayer()(copy-paste bug). The model now stores$payerand$payeeas separate fields;parse()maps them from the correct API keys.#15 —
getBaseUrl()fell through toPRODUCTION_URLfor any unknown environment string (typo risk). Now throwsInvalidArgumentExceptionfor values not matching a known constant.