fix(demo): restore the database, category and icon fields in the demo fixtures#1100
Merged
Conversation
… fixtures The demo fixtures had drifted from the shape the real API returns, and the UI's fallbacks hid it rather than breaking loudly. No entry in services.json carried is_database, so the Databases tab was gated off everywhere in the demo despite databases.json and its stub endpoint being present and populated. It is now set on mysql, postgres and mariadb-11, matching what the server derives from IsDBServiceName. Neither fixture carried category or icon, so every service and preset fell back to the "other" bucket and the generic glyph, collapsing the sidebar and the discovery grid into one undifferentiated Other section. Both fields are now backfilled from the category and icon declared in the service store and the bundled presets, so the fixtures track the real definitions instead of invented values. The per-site entries for queues, schedules, reverb, stripe and vite deliberately keep no category, since they have no preset behind them and the sidebar groups them by their site fields instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The demo fixtures had drifted from the shape the real API returns, and the UI's fallbacks hid it rather than breaking loudly.
No entry in services.json carried is_database, so the Databases tab was gated off everywhere in the demo despite databases.json and its stub endpoint being present and populated. It is now set on mysql, postgres and mariadb-11, matching what the server derives from IsDBServiceName.
Neither fixture carried category or icon, so every service and preset fell back to the "other" bucket and the generic glyph, collapsing the sidebar and the discovery grid into one undifferentiated Other section. Both fields are now backfilled from the category and icon declared in the service store and the bundled presets, so the fixtures track the real definitions instead of invented values.
The per-site entries for queues, schedules, reverb, stripe and vite deliberately keep no category, since they have no preset behind them and the sidebar groups them by their site fields instead.
Note that merging this alone will not update lerd.sh, since the Docs workflow only runs on version tags or a manual dispatch.