release: v1.30.1#1104
Merged
Merged
Conversation
The open-terminal button on a site launched ptyxis with a bare --working-directory flag. ptyxis is single-instance and applies that flag only when it is paired with --new-window, --tab or -x, so a plain launch ignored the directory and raised a new window in the home directory instead of the project. It reached anyone whose terminal resolved to ptyxis, the default on Fedora and on Ubuntu installs that carry it, while one-window-per-process emulators were unaffected. The button passes --new-window alongside --working-directory now, so ptyxis opens the new window in the site or worktree path. Closes #1103
This patch carries two fixes on top of 1.30.0. On macOS lerd stopped prompting to reinstall the DNS sudoers rule on every lerd start, where the passwordless liveness probe was hardcoded to a Linux only tool and read its own inevitable refusal as proof the grant was gone. And the web UI open-terminal button opens in the site directory again where ptyxis is the terminal, rather than falling back to the home directory. The version bumps to 1.30.1 and the changelog gains a 1.30.1 section above 1.30.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lerd 1.30.1 is a patch on top of 1.30.0 with two fixes.
On macOS lerd stopped prompting to reinstall the DNS sudoers rule on every
lerd start. The passwordless liveness probe that decides whether the drop-in is still live was hardcoded to resolvectl, a Linux only tool the macOS drop-in never grants, so sudo always refused and the probe read that as the grant being gone, rewriting the rule on every run even when the installed file was byte identical to its recorded hash. The probe is platform specific now, exercisingmkdir -p /etc/resolveron macOS, a command the drop-in already grants.The other fix is the web UI open-terminal button, which opened in the home directory rather than the site path wherever ptyxis is the terminal, the default on Fedora and on Ubuntu installs that carry it. ptyxis is single-instance and honours
--working-directoryonly alongside--new-window,--tabor-x, so the bare flag lerd passed was ignored. It passes--new-windownow.Closes #1103