fix(host-proxy): show proxy-only sites as running when their port is listening#1109
Merged
Conversation
…listening The site status dot in the sites list and dashboard is driven by fpm_running, which for a host-proxy site was computed only from its supervised dev-server unit. Proxy-only sites, where you start the dev server yourself and lerd only wires the proxy, have no such unit, so fpm_running was always false and the dot stayed grey even while the server was up and serving. For proxy-only sites the running state now follows the proxied port: a short TCP probe of the host port, reusing the same dial seam the worker health checks already use. A green dot means your dev server is listening on the port lerd proxies to. Supervised host-proxy sites keep reflecting their worker unit exactly as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site status dot in the sites list and dashboard is driven by fpm_running, which for a host-proxy site was computed only from its supervised dev-server unit. Proxy-only sites, where you start the dev server yourself and lerd only wires the proxy, have no such unit, so fpm_running was always false and the dot stayed grey even while the server was up and serving.
For proxy-only sites the running state now follows the proxied port: a short TCP probe of the host port, reusing the same dial seam the worker health checks already use. A green dot means your dev server is listening on the port lerd proxies to. Supervised host-proxy sites keep reflecting their worker unit exactly as before.
Refs #1108