fix(ui): offer the Logs tab when a site's only source is a worker#1111
Open
geodro wants to merge 1 commit into
Open
fix(ui): offer the Logs tab when a site's only source is a worker#1111geodro wants to merge 1 commit into
geodro wants to merge 1 commit into
Conversation
The site detail gated its Logs tab on app logs, a PHP-FPM or container runtime, or a supervised dev server. A site whose sole log source is a background worker, such as a proxy-only host-proxy site running a Stripe listener, matched none of those, so the whole Logs tab was hidden even though the inner logs view would have built a Stripe sub-tab and the stream worked. Whether to offer the tab now runs through a single siteHasLogSources helper that mirrors the sources the logs view actually builds, running or failing workers included, so the tab appears exactly when there is something to show.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site detail gated its Logs tab on app logs, a PHP-FPM or container runtime, or a supervised dev server. A site whose sole log source is a background worker, such as a proxy-only host-proxy site running a Stripe listener, matched none of those, so the whole Logs tab was hidden even though the inner logs view would have built a Stripe sub-tab and the stream worked.
Whether to offer the tab now runs through a single siteHasLogSources helper that mirrors the sources the logs view actually builds, running or failing workers included, so the tab appears exactly when there is something to show.
Refs #1110