Repository navigation
Fix regional ALDI and aktiv & irma offers; release 0.1.65 - #63
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native ALDI Nord and Süd previously loaded national offers after validating only the postal-code syntax. aktiv & irma had the same problem in the app and server. Munich could therefore show ALDI Nord and Oldenburg-only offers.
Check both ALDI chains against official German store coordinates within 15 km, retaining both chains in border areas. Resolve postal areas missing from the store lists through Nominatim, with bounded responses, caching, request spacing and in-app attribution/disclosure. Require an exact supermarket match for aktiv & irma; offices and beverage shops do not qualify.
Carry confirmed market absence separately from fetch errors through native, scheduled and server refreshes. Remove only confirmed non-local offer rows, retaining shopping lists, favorites, products and offline data on transport errors. A configured server fallback cannot bypass a confirmed negative market check. Server retailer filters respect the automatic ALDI region, and cached region diagnostics follow the requested postal code.
The release also preserves the previously installed local MCP alternative-search fix: phrase alternatives are queried independently and merged by offer ID, retaining existing filters. Its module hash matches the running production hotfix.
Release 0.1.65 includes Android and server changes. Existing signing identity and database schema are preserved. No F-Droid publishing tag or external review comments are part of this release.
Validation: 492 offline Python tests, Ruff and Bandit; Android unit suites for both build variants; replay of captured official retailer responses for Munich, Leipzig and Oldenburg; live aktiv & irma requests. 20 Android 9 AOSP device tests passed, including Room cache removal while retaining shopping lists, favorites and products. Android build, unit suites and lint passed.