Remove ex_compact dependency#57
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ex_termbox's waf build uses Python's `imp` module, removed in 3.12+. Pin Python 3.11 in CI to provide compatibility. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ex_termbox's waf build tool is incompatible with Python 3.12+ (removed 'imp' module and 'rU' file mode). Since the TUI is never tested in CI, restrict ratatouille to dev/prod environments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Wrap TUI app and mix tui task in compile-time check so they're skipped when ratatouille is not available (test env in CI). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Styler wants defmodule/defp indented inside `if Code.ensure_loaded?` blocks. Formatting app.ex, cortex.ex, and tui.ex to match. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extracted helpers to reduce nesting depth and cyclomatic complexity across 36 files. Fixed ExpensiveEmptyEnumCheck in tests, removed duplicate boolean operand, and dropped unused Logger metadata key. Updated CLAUDE.md to require zero credo issues instead of allowing a ~40-issue baseline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add ExUnit.configure exclude: [:llm, :external] to test_helper - Tag ObsidianTemporal build/3 tests as :external (need obsidian-cli) - Muse ask/2 tests already tagged :llm (need Ollama) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ThreatTracker.check/1 calls Settings.resolve/2 which hits the DB, but the test used ExUnit.Case without Ecto sandbox setup. Async embeddings tasks from other tests would race for the connection pool. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Disable async embeddings in test env via config flag (no Ollama in CI) - Add catch :exit to AppTelemetry.fetch_rumination_name (DB may be unavailable during shutdown or test teardown) - Add catch :exit to Obsidian.Sync guard functions (sync_enabled?, vault_path) — these are best-effort and should never crash callers Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Remove the `name: Build & Test` override so the job reports as `ci` matching the branch protection required status check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Revert job name removal — keep `name: Build & Test` and update the branch protection required check to match. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ex_compactpath dependency from mix.exsTest plan
mix deps.getsucceeds🤖 Generated with Claude Code