Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies API response fields for Calendar and Goal domains to support improved app structure. The changes involve restructuring response DTOs by removing some fields from certain responses and adding others.
- Removed
categoryIdandcalendarIdfromWeeklyGoalResponsewhile addingweekfield - Added
categoryIdtoCalendarResponseandcalendarIdtoWeeklyGoalDetailsResponse - Simplified
MonthlyGoalListResponseby removingcategoryIdandcalendarIdfields
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CustomWeeklyGoalRepository.java | Enhanced query to fetch additional related entities (category, relatedMonthlyGoal) |
| WeeklyGoalResponse.java | Restructured response fields: removed categoryId/calendarId, added week field |
| WeeklyGoalDetailsResponse.java | Added calendarId field to detailed response |
| MonthlyGoalListResponse.java | Simplified response by removing categoryId and calendarId fields |
| CalendarResponse.java | Added categoryId field to calendar response |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
이슈 번호 (#342)
요약