fix: 修复 Safari HLS fallback、插件销毁跳过、React ref null、换集旧 ID、菜单残留、Vue 缺失 props - #45
Merged
Merged
Conversation
…props
- core: Safari 原生 HLS fallback 不再被 import('hls.js') 错误阻断
- core: 插件销毁 forEach+splice 改为复制数组遍历,修复跳过一半
- core: load() 清空 engine-managed 画质/音轨菜单,修复换源后残留
- core: 新增 setId(id) 切换视频 ID,保存旧进度后重新绑定
- react: useImperativeHandle 去掉 deps=[],修复 ref 始终 null
- react: watch id prop 变化调用 setId
- vue: 补全 loop/shareUrl/onSavePrefs/onSaveProgress props
- vue: watch id prop 变化调用 setId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 6 个 review 发现的问题
#1 Safari 原生 HLS fallback 被 import 错误阻断 (高)
canPlayType,再 import hls.js#2 React ref 始终 null (高)
useImperativeHandle的 deps 从[]改为无 deps#3 换集时进度写入旧 ID (高)
setId(id)方法:保存旧进度 → 解绑旧事件 → 重新绑定idprop watch,变化时调用setId#4 插件销毁跳过一半 (高)
forEach+splice改为[...arr].forEach#5 换源后画质/音轨菜单残留 (中)
load()清空 engine-managed 菜单,重置标志#6 Vue 缺失 props (中)
loop、shareUrl、onSavePrefs、onSaveProgress测试