Fix token object support in tokenStore (fixes #143)#145
Merged
Conversation
The refresh_access_token() function documents support for both token file paths and token objects, but tokenStore.get() and tokenStore.store() assumed token was always a path, causing failures with in-memory tokens. Changes: - get(): Return token object as-is when passed an object - store(): Skip filesystem write when token_path is an object - Add tests to verify object token handling 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tokenStore.get()to return token object as-is when passed an object instead of a pathtokenStore.store()to skip filesystem write whentoken_pathis an objectFixes #143
Problem
The
refresh_access_token()function documents support for both token file paths and token objects:However,
tokenStore.get()andtokenStore.store()unconditionally assumed token was a file path, causing runtime errors when using in-memory token objects (e.g., from environment variables).Test plan
token-store.jsto handle object tokensnpm test)🤖 Generated with Claude Code