Simple basic auth #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implemented very simple authentication with basic auth. * Introduced a logged_in? method in the application controller to easily use in the views to show/hide authenticated user actions and information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ArticlesControllernow require authentication exceptshowandindex. Username and password are stored as environment variables.logged_in?method in the application controller to easily use in the views to show/hide authenticated user actions and information.Any comments or suggestions @joeljunstrom?
I would also like to make it possible to login and logout just by requesting those paths (
/loginand/logout) but I got stuck while trying to figure out where to place that logic. Would it make sense to create aAuthenticationControllerfor this?