[leynos]

Repins install-whitaker to shared-actions 5a99aed78ce68dcebd3052b75c31e6f173162b1e (leynos/shared-actions#651, approved as a QG-002 root by leynos/concordat#331). That revision defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot instead of cloning Clippy's deleted master branch, so cold lint lanes work again. Part of DF12-89.

• Pin only, with no trailing version comment.
• A cache-restored driver rebuilds once (about a minute); that is expected.

Summary by Sourcery

Repin the CI Whitaker installer action to the approved revision so cold lint lanes work reliably again.

Bug Fixes:

• Repin the Whitaker installer action to a revision that restores cold lint lane compatibility with the current installer.

CI:

• Update the CI workflow to use the approved shared-actions revision for installing Whitaker.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T05:08:24.034202Z	f014966	PR opened
🔒 Security Review	✅ Completed 2026-10-30T05:09:52.743876Z	f014966	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: f014966

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Team
• Run ID: 1632477d-8de2-436d-bd09-224ca1aa9cd5

Commits

Reviewing files that changed from the base of the PR and between 862c21d and f014966.

Files selected for processing: 1

• .github/workflows/ci.yml

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Update the Whitaker installation action in .github/workflows/ci.yml to shared-actions revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e. Keep cranelift: true unchanged.

Test results are unavailable.

Walkthrough

The CI workflow now uses revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e of the shared Whitaker installation action. The cranelift input is unchanged.

Changes

CI action pin

Layer / File(s)	Summary
Update Whitaker action pin .github/workflows/ci.yml	The workflow references the new Whitaker installation action revision. The cranelift input remains unchanged.

Possibly related issues

• leynos/whitaker#530 — The PR adopts the Whitaker bootstrap through the shared installation action revision.

Possibly related PRs

• leynos/netsuke#1042 — Updates the installation action to the same shared-actions revision.
• leynos/mapsplice#189 — Pins the installation action to the same revision for the cold driver-build issue.
• leynos/cabochon#74 — Uses the same action revision for the cold-build issue.

Priority: Normal

Change: Bug fix

Merge Risk: Minimal · up to f0149

The Whitaker action revision changes while the existing cranelift input remains unchanged; the PR is mergeable.

Pre-merge checks: 15

Check name	Status	Explanation
Title check		Accept the title. It accurately identifies the install-whitaker repin and the target revision. No GitHub issue number is required because the description does not reference an existing GitHub issue.
Description check		Accept the description. It explains the pin update, the installer change, the expected lint-lane effect, and the expected cache rebuild.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Testing (Overall)		The pull request changes only the pinned revision of the third-party install-whitaker GitHub Action. It does not add local functionality or repository behaviour that requires new tests. The existing…
User-Facing Documentation		PASS — The pull request changes only the pinned revision of the CI-only install-whitaker action. It does not change user-facing functionality, behaviour, interfaces, or release compatibility. No use…
Developer Documentation		Pass the documentation check. The pull request changes only the pinned SHA for the existing install-whitaker CI action; cranelift: true and the workflow contract remain unchanged. `docs/developers…
Module-Level Documentation		Pass. The pull request changes only the pinned revision of the install-whitaker GitHub Action in .github/workflows/ci.yml. It adds or changes no module, so the module-level documentation requireme…
Testing (Unit And Behavioural)		PASS — The pull request changes only the SHA for the install-whitaker action in .github/workflows/ci.yml. It does not change product code or local behaviour. The workflow already exercises the act…
Testing (Property / Proof)		The pull request changes only one CI action revision in .github/workflows/ci.yml. It does not introduce a new invariant over inputs, states, orderings, or transitions, and it adds no lemma or proof …
Testing (Compile-Time / Ui)		Pass the check. The pull request changes only the pinned revision of the external install-whitaker GitHub Action in .github/workflows/ci.yml. It does not change Rust or TypeScript compile-time beh…
Unit Architecture		PASS: The pull request changes only the pinned revision of the existing install-whitaker GitHub Action in .github/workflows/ci.yml. It does not add or alter application queries, commands, fallible…
Domain Architecture		The pull request changes only the pinned revision of the CI install-whitaker action. It does not change domain code, adapters, repositories, commands, or business rules. The cranelift: true input …
Observability		Pass. Keep the pin-only change. The diff updates one GitHub Actions revision in .github/workflows/ci.yml; it does not change production behaviour, service boundaries, throughput, latency, retries, c…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Testing (Overall)

Explanation

The pull request changes only the pinned revision of the third-party install-whitaker GitHub Action. It does not add local functionality or repository behaviour that requires new tests. The existing workflow still runs make lint and coverage tests after installation. The check does not require tests to verify third-party tool behaviour.

Full details: User-Facing Documentation

Explanation

PASS — The pull request changes only the pinned revision of the CI-only install-whitaker action. It does not change user-facing functionality, behaviour, interfaces, or release compatibility. No user-guide or migration-document update is required.

Full details: Developer Documentation

Explanation

Pass the documentation check. The pull request changes only the pinned SHA for the existing install-whitaker CI action; cranelift: true and the workflow contract remain unchanged. docs/developers-guide.md already documents Whitaker in the lint workflow and the policy for shared-action pins. No new API, architectural boundary, design decision, build requirement, roadmap item, or execplan is introduced.

Full details: Module-Level Documentation

Explanation

Pass. The pull request changes only the pinned revision of the install-whitaker GitHub Action in .github/workflows/ci.yml. It adds or changes no module, so the module-level documentation requirement is not applicable.

Full details: Testing (Unit And Behavioural)

Explanation

PASS — The pull request changes only the SHA for the install-whitaker action in .github/workflows/ci.yml. It does not change product code or local behaviour. The workflow already exercises the action in sequence with dependency auditing, linting, coverage tests, and doctests. No additional unit or behavioural test is required for this pin-only change.

Full details: Testing (Property / Proof)

Explanation

The pull request changes only one CI action revision in .github/workflows/ci.yml. It does not introduce a new invariant over inputs, states, orderings, or transitions, and it adds no lemma or proof assumption. Property testing or exhaustive proof is therefore not applicable.

Full details: Testing (Compile-Time / Ui)

Explanation

Pass the check. The pull request changes only the pinned revision of the external install-whitaker GitHub Action in .github/workflows/ci.yml. It does not change Rust or TypeScript compile-time behaviour, text output, structured output, or UI behaviour. No trybuild or snapshot test is required by this check.

Full details: Unit Architecture

Explanation

PASS: The pull request changes only the pinned revision of the existing install-whitaker GitHub Action in .github/workflows/ci.yml. It does not add or alter application queries, commands, fallible APIs, dependencies, state mutation, or tests. No Unit Architecture failure condition is introduced.

Full details: Domain Architecture

Explanation

The pull request changes only the pinned revision of the CI install-whitaker action. It does not change domain code, adapters, repositories, commands, or business rules. The cranelift: true input remains unchanged, so this check has no architecture violation.

Full details: Observability

Explanation

Pass. Keep the pin-only change. The diff updates one GitHub Actions revision in .github/workflows/ci.yml; it does not change production behaviour, service boundaries, throughput, latency, retries, cache policy, or alert conditions. Keep cranelift: true unchanged. No additional logs, metrics, traces, or alerts are required by this check.

_{Pin the action to its new revision.
Keep cranelift as it was.
Let the workflow follow the updated reference.
Check the pin in the CI file.
Then send the build on its way.}

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 6 days and 16 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI workflow to pin install-whitaker to shared-actions commit 5a99aed7, which defaults to whitaker-installer 0.2.11 and builds the Dylint driver from a verified Clippy snapshot instead of the deleted Clippy master branch.

Sequence diagram for the pinned Whitaker driver installation

sequenceDiagram
    participant CI
    participant InstallWhitaker
    participant WhitakerInstaller
    participant ClippySnapshot
    participant DylintDriver

    CI->>InstallWhitaker: install-whitaker@5a99aed7
    InstallWhitaker->>WhitakerInstaller: whitaker-installer 0.2.11
    WhitakerInstaller->>ClippySnapshot: use verified Clippy snapshot
    ClippySnapshot-->>WhitakerInstaller: snapshot available
    WhitakerInstaller->>DylintDriver: build Dylint driver
    DylintDriver-->>CI: driver ready

Loading

File-Level Changes

Change	Details	Files
Repin the Whitaker installer action to the shared-actions revision that uses whitaker-installer 0.2.11.	Update the immutable action SHA used by the CI Whitaker installation step. Retain Cranelift installation configuration and omit a trailing version comment. Use the verified Clippy snapshot-based driver build to restore cold lint lane support; expect one cache-restored rebuild.	.github/workflows/ci.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.