Repository navigation
Conversation
Move assignment-validation cases and their model into a sibling module, and move the functional clustering quality assertion into another. Keep Cargo test roots and test bodies intact while bringing both oversized integration-test files under the 400-line module budget.
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. Summary
Validation
WalkthroughThe test suite moves assignment-validation tests into a dedicated module and moves the shared quality-score assertion helper into a separate module. ChangesAssignment Validation Tests
Quality Assertion Helper
Priority: ⬇️ Low Change: Refactor Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established; the change is mergeable after normal checks. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Move the tests to a clearer place, Comment |
Reviewer's GuideRefactors two oversized core integration-test roots into private sibling modules, preserving existing test bodies, function identifiers, Cargo integration-test discovery, and behavior while keeping all affected files within the module-size budget. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
leynos
marked this pull request as ready for review
September 24, 2026 07:16
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch moves the assignment-validation cases and their independent model
from an oversized core integration test root into a private sibling module. It
also moves the functional clustering quality assertion into a private sibling
module. Both Cargo integration test roots and the existing test function
identifiers remain; every affected Rust file is below the 400-line module
budget.
This structural layer follows #295
and precedes the assertion-message lint wave.
Review walkthrough
Validation
git diff --checkpassed.make test NEXTEST_ARGS='-p chutoro-core --test chutoro --test functional_ari_nmi': 714 Nextest tests passed, with the established skips and stable verification leaves. The initial formatter check requested only module declaration ordering; that correction was applied before the final gate run.make check-fmt,make spelling,make markdownlint,make nixie,make typecheck,make lint(including Whitaker),make test-workflow-contracts(446 passed), andmake test(1,242 Nextest tests passed, three established skips, plus stable API, SIMD and poisoned-lock checks) all passed.make verus: 21 and 4 proofs verified.make kani: six configured harnesses verified. Stablecargo test --workspace --doc --all-featureswith warnings denied: 137 passed, 17 ignored./tmp/chutoro-c7059fd9-integration-test-structure/gates-20260924-run2/.Notes
Moved assignment tests gain an
assignment_validation::segment in their fully qualified Rust harness names. No repository Make, Nextest or CI selector names these cases exactly.Ancestor #282 is blocked by hosted CodeScene project configuration lacking
gates, tracked in #283. This branch's hosted checks and changed-line coverage require separate current-head assessment.Summary by Sourcery
Extract oversized core integration-test components into focused private sibling modules without changing test behavior or discovery.
Enhancements:
Tests:
References