Repository navigation
Repin install-whitaker to 5a99aed7 (whitaker-installer 0.2.11) - #418
Conversation
Upstream Dylint 6.0.1 clones Clippy's master branch, which no longer exists, so every cold Whitaker driver build fails. shared-actions 5a99aed7 (#651), approved as a root by concordat QG-002, makes install-whitaker default to whitaker-installer 0.2.11, which builds the driver from a verified Clippy snapshot.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update the Whitaker action pin .github/workflows/ci.yml |
The installation step now uses revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e instead of 872f59f53717b5bebe8e24b2f4a7496b089a939a. |
Possibly related issues
- Whitaker issue 530 tracks the released installer and bootstrap acceptance evidence supplied by the shared action revision used here.
Possibly related PRs
- leynos/tei-rapporteur#225: Pins the same shared
install-whitakeraction revision. - leynos/msgspec-crockford#54: Pins the same shared action revision and selects installer 0.2.11.
- leynos/mpsc-log#114: Applies the same action pin while retaining the Cranelift setting.
Suggested labels: Issue
Change: Bug fix
Merge Risk: 
6dd61
-
No actionable merge-blocking risk was identified in the reviewed change.
Caution
Pre-merge checks failed
Please resolve all errors before merging. Addressing warnings is optional.
- Ignore
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Testing (Unit And Behavioural) |  |
Add behavioural coverage for the changed CI integration. The PR changes only the install-whitaker action revision in .github/workflows/ci.yml. No test file changes cover this action. Existing work… |
Add a workflow contract test for the Whitaker action reference and its ordering before make lint. Run the lint lane with a cold cache and verify that the pinned installer builds the driver and that make lint completes successfully. |
| Developer Documentation |  |
The pull request changes the CI tooling pin from install-whitaker revision 872f59f... to 5a99aed.... The new revision changes the Whitaker installer behaviour to whitaker-installer 0.2.11, but… |
Update docs/developers-guide.md with the Whitaker installation requirement and the reason for the pinned install-whitaker revision. Keep the documentation aligned with the CI workflow, or do not change the tooling requirement. |
-
Check name Status Explanation Title check Keep the title. It clearly describes the change to repin the Whitaker installation action and does not require a repository issue number based on the supplied context. Description check Keep the description. It explains the Whitaker repin, the failure cause, the affected file, and the validation gate. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) Pass this check. The pull request changes one workflow action pin only: it moves install-whitakerto a new third-party revision. It adds no repository functionality or local behavioural logic. The w…User-Facing Documentation The pull request changes only the pinned revision of the install-whitakeraction in.github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality or …Module-Level Documentation Pass the check. The pull request changes only the revision of the install-whitakeraction in.github/workflows/ci.yml. It introduces no module, so the module-level documentation requirement does n…Testing (Property / Proof) The pull request changes one GitHub Actions revision in .github/workflows/ci.yml. It introduces no invariant over inputs, states, orderings, or transitions, and it introduces no lemma or proof assum…Testing (Compile-Time / Ui) Pass the testing check. The pull request changes only the install-whitakerrevision in.github/workflows/ci.yml; it changes no Rust or TypeScript compile-time behaviour and adds no text or UI outp…Unit Architecture Pass. The pull request changes only the pinned revision of the existing install-whitakerGitHub Action in.github/workflows/ci.yml. It does not change queries, commands, fallible APIs, dependency …Domain Architecture Pass this check. The pull request changes only the pinned revision of the CI install-whitakeraction in.github/workflows/ci.yml. It does not change domain code, adapters, repositories, commands, …Observability PASS — The pull request changes only the pinned revision of the existing install-whitakerCI action in.github/workflows/ci.yml. It introduces no production runtime behaviour, service boundary, qu…Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Testing (Overall)
-
Explanation
Pass this check. The pull request changes one workflow action pin only: it moves
install-whitakerto a new third-party revision. It adds no repository functionality or local behavioural logic. The workflow already runsmake lintandmake test-workflow-contracts. The check does not require tests to verify that a third-party tool or action works as advertised.
Full details: User-Facing Documentation
-
Explanation
The pull request changes only the pinned revision of the
install-whitakeraction in.github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality or behaviour. No users-guide update is required.
Full details: Module-Level Documentation
-
Explanation
Pass the check. The pull request changes only the revision of the
install-whitakeraction in.github/workflows/ci.yml. It introduces no module, so the module-level documentation requirement does not apply.
Full details: Testing (Property / Proof)
-
Explanation
The pull request changes one GitHub Actions revision in
.github/workflows/ci.yml. It introduces no invariant over inputs, states, orderings, or transitions, and it introduces no lemma or proof assumption. Property testing and exhaustive proof are therefore not applicable.
Full details: Testing (Compile-Time / Ui)
-
Explanation
Pass the testing check. The pull request changes only the
install-whitakerrevision in.github/workflows/ci.yml; it changes no Rust or TypeScript compile-time behaviour and adds no text or UI output. Trybuild or snapshot tests are therefore not applicable.
Full details: Unit Architecture
-
Explanation
Pass. The pull request changes only the pinned revision of the existing
install-whitakerGitHub Action in.github/workflows/ci.yml. It does not change queries, commands, fallible APIs, dependency injection, state mutation, or tests. The Unit Architecture conditions do not apply to this pin-only workflow change.
Full details: Domain Architecture
-
Explanation
Pass this check. The pull request changes only the pinned revision of the CI
install-whitakeraction in.github/workflows/ci.yml. It does not change domain code, adapters, repositories, commands, or business rules. Therefore, it introduces no domain-boundary violation.
Full details: Observability
-
Explanation
PASS — The pull request changes only the pinned revision of the existing
install-whitakerCI action in.github/workflows/ci.yml. It introduces no production runtime behaviour, service boundary, queue, retry, cache, or resource-consumption change. The existingLintstep remains directly after the installation step and reports Whitaker diagnostics through CI logs. No new metrics, tracing, alerts, or logging are required by this pin-only change.
-
Full details: Testing (Unit And Behavioural)
-
Explanation
Add behavioural coverage for the changed CI integration. The PR changes only the
install-whitakeraction revision in.github/workflows/ci.yml. No test file changes cover this action. Existing workflow tests cover unrelated contracts, and the build-standard tests do not inspect Whitaker installation. The change affects the externally observable CI workflow and its network-backed installer boundary.Resolution
Add a workflow contract test for the Whitaker action reference and its ordering before
make lint. Run the lint lane with a cold cache and verify that the pinned installer builds the driver and thatmake lintcompletes successfully.
Full details: Developer Documentation
-
Explanation
The pull request changes the CI tooling pin from
install-whitakerrevision872f59f...to5a99aed.... The new revision changes the Whitaker installer behaviour towhitaker-installer0.2.11, but the only changed file is.github/workflows/ci.yml.docs/developers-guide.mddocuments themake lintcommand and Whitaker rule behaviour, but it does not document the installer, the pin, or the cold-build requirement. No design or roadmap change applies.Resolution
Update
docs/developers-guide.mdwith the Whitaker installation requirement and the reason for the pinnedinstall-whitakerrevision. Keep the documentation aligned with the CI workflow, or do not change the tooling requirement.
Pin the action to its new place
Let Whitaker follow the trace
One revision, clearly in view
The workflow knows which commit to use
Keep the linting step on cue
Comment @coderabbitai help to get the list of available commands.
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe CI workflow makes a pin-only update to the Whitaker installer action, switching to the approved shared-actions revision for whitaker-installer 0.2.11 and fixing cold Dylint driver builds affected by upstream Clippy branch removal. Sequence diagram for the pinned Whitaker CI lint setupsequenceDiagram
participant CI as CI lint job
participant Action as install-whitaker action
participant Installer as whitaker-installer 0.2.11
participant Dylint as Dylint driver
participant Lint as make lint
CI->>Action: Run pinned revision 5a99aed7
Action->>Installer: Install whitaker-installer 0.2.11
Installer->>Dylint: Build driver from verified Clippy snapshot
Dylint-->>Action: Driver ready
Action-->>CI: Whitaker suite installed
CI->>Lint: Run make lint
Lint->>Dylint: Execute lint checks
Dylint-->>CI: Return diagnostics
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved as a root by concordat QG-002). The action then defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot: upstream Dylint 6.0.1 clones Clippy'smaster, which no longer exists, so every cold Whitaker driver build fails.Pin-only: the files changed are (.github/workflows/ci.yml ) and only the install-whitaker revision moves. The previous pin was not an approved QG-002 revision.
Other Whitaker paths
None found: no bare
cargo dylint,cargo binstall whitaker, hand-rolled installer or explicitinstaller-versionoutside the action and thewhitakerwrapper.Notes
A cache-restored driver rebuilds once (about a minute); that is expected. Gate: CI green on the lint lane at the head, with the lint job's log read for Whitaker's diagnostics.
Summary by Sourcery
Repin the CI Whitaker installation action to the approved revision to keep Dylint driver builds working.
Bug Fixes:
CI: