Repository navigation
Repin install-whitaker to the 0.2.11 revision - #161
Conversation
Pin install-whitaker to shared-actions 5a99aed78ce68dcebd3052b75c31e6f173162b1e, which defaults the installer to 0.2.11 and builds the Dylint driver from a verified Clippy snapshot. Upstream Dylint 6.0.1 clones Clippy's deleted master branch, so every cold driver build failed. Any explicit installer-version is set to 0.2.11.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Update the installer pin .github/workflows/ci.yml |
Pin the Whitaker installer step to revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e. |
Possibly related issues
- leynos/axinite#675 — The workflow changes the immutable
install-whitakerreference discussed in this issue; this PR does not change contract tests. - leynos/whitaker#530 — The new action revision adopts the shared installer release through a downstream workflow pin.
- leynos/whitaker#529 — The new pin adopts a revision associated with the Clippy snapshot bootstrap policy; this PR does not change adapters.
Possibly related PRs
- leynos/corbusier#249 — Both PRs update the
install-whitakerreference to revision5a99aed78ce68dcebd3052b75c31e6f173162b1e. - leynos/ddlint#416 — Both PRs change the same installer pin to the same revision.
- leynos/diesel-cte-ext#200 — Both PRs make the same pin-only workflow change.
Priority:
Change: Bug fix
Merge Risk: 
8d6e7
-
No actionable merge-blocking risk is identified in this pin-only workflow change.
Pre-merge checks: 
-
Check name Status Explanation Title check The title directly identifies the workflow pin change and the target 0.2.11 revision. No roadmap item or GitHub issue number is required by the supplied context. Description check The description explains the pin update, target revision, installer version, and failure it addresses. It is directly related to the changeset. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Testing (Overall) Pass the testing check. The pull request changes only the pinned revision of the third-party install-whitakerGitHub Action in.github/workflows/ci.yml; it adds no repository functionality or loca…User-Facing Documentation The pull request changes only the pinned revision of the install-whitakeraction in.github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality or …Developer Documentation Pass the developer documentation check. The pull request changes only the pinned SHA of the existing install-whitakerCI action in.github/workflows/ci.yml. It adds no internal API, architectural …Module-Level Documentation Pass. The pull request changes only one GitHub Actions pin in .github/workflows/ci.yml. It adds or changes no source module, so this module-level documentation check is not applicable.Testing (Unit And Behavioural) PASS — The pull request changes only one GitHub Actions revision in .github/workflows/ci.yml. It adds no local production behaviour, unit-testable logic, edge case, or error path. The workflow still…Testing (Property / Proof) Pass this check. The pull request changes one GitHub Actions reference from one immutable install-whitakerrevision to another. It introduces no input-dependent invariant, state transition, lemma, o…Testing (Compile-Time / Ui) PASS. The pull request changes one GitHub Actions reference in .github/workflows/ci.ymlfrom oneinstall-whitakerrevision to another. It adds no Rust or TypeScript compile-time behaviour and prod…Unit Architecture PASS. Treat this as an inapplicable architecture change: the pull request changes only one GitHub Actions revision in .github/workflows/ci.yml(line 39). It adds no query, command, fallible API, dep…Domain Architecture The pull request changes one GitHub Actions reference only: it repins install-whitakerto revision5a99aed78ce68dcebd3052b75c31e6f173162b1e. It changes no domain code, adapters, repositories, comm…Observability PASS. The pull request changes only the pinned revision of the named Install Whitaker Dylint suiteGitHub Actions step in.github/workflows/ci.yml. It changes CI tool provisioning, not production …Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Full details: Testing (Overall)
-
Explanation
Pass the testing check. The pull request changes only the pinned revision of the third-party
install-whitakerGitHub Action in.github/workflows/ci.yml; it adds no repository functionality or local configuration logic. The check explicitly does not require tests to verify third-party tools. Existing CI still runs lint, tests, and workflow contract checks.
Full details: User-Facing Documentation
-
Explanation
The pull request changes only the pinned revision of the
install-whitakeraction in.github/workflows/ci.yml. This updates CI tooling and does not introduce or change user-facing functionality or behaviour. No user-guide update is required.
Full details: Developer Documentation
-
Explanation
Pass the developer documentation check. The pull request changes only the pinned SHA of the existing
install-whitakerCI action in.github/workflows/ci.yml. It adds no internal API, architectural boundary, design decision, project build requirement, or new developer-facing tool. Existing documentation covers workflow pin policy and themake lintbuild behaviour. No roadmap or execplan update is required.
Full details: Testing (Unit And Behavioural)
-
Explanation
PASS — The pull request changes only one GitHub Actions revision in
.github/workflows/ci.yml. It adds no local production behaviour, unit-testable logic, edge case, or error path. The workflow still exercises the installed Whitaker suite throughmake lint, and the repository retains workflow contract tests. No additional unit test is required for this pin-only change.
Full details: Testing (Property / Proof)
-
Explanation
Pass this check. The pull request changes one GitHub Actions reference from one immutable
install-whitakerrevision to another. It introduces no input-dependent invariant, state transition, lemma, or proof assumption. Property tests and exhaustive proofs are therefore not applicable.
Full details: Testing (Compile-Time / Ui)
-
Explanation
PASS. The pull request changes one GitHub Actions reference in
.github/workflows/ci.ymlfrom oneinstall-whitakerrevision to another. It adds no Rust or TypeScript compile-time behaviour and produces no text-based or UI output requiring snapshot coverage. The trybuild and snapshot requirements are therefore not applicable.
Full details: Unit Architecture
-
Explanation
PASS. Treat this as an inapplicable architecture change: the pull request changes only one GitHub Actions revision in
.github/workflows/ci.yml(line 39). It adds no query, command, fallible API, dependency, state mutation, or test unit. No explicit Unit Architecture failure condition is introduced.
Full details: Domain Architecture
-
Explanation
The pull request changes one GitHub Actions reference only: it repins
install-whitakerto revision5a99aed78ce68dcebd3052b75c31e6f173162b1e. It changes no domain code, adapters, repositories, commands, or persistence boundaries. The Domain Architecture check therefore has no failure condition to report.
Full details: Observability
-
Explanation
PASS. The pull request changes only the pinned revision of the named
Install Whitaker Dylint suiteGitHub Actions step in.github/workflows/ci.yml. It changes CI tool provisioning, not production runtime behaviour. The workflow already exposes separateInstall Whitaker Dylint suiteandLintfailure boundaries, and no new service, queue, storage, throughput, latency, or retry behaviour requires metrics or tracing.
-
Pin the action, set the flow,
Let the Whitaker checks now go.
A new revision takes its place,
CI follows the updated trace.
Keep the workflow pin in view.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe CI workflow updates the install-whitaker action to the approved shared-actions revision that uses whitaker-installer 0.2.11 and avoids failing cold Whitaker driver builds; no other installation paths or workflow behavior change. Sequence diagram for the pinned Whitaker CI installationsequenceDiagram
participant CI as GitHub Actions CI
participant Action as install-whitaker action
participant Installer as whitaker-installer 0.2.11
participant Lint as make lint
CI->>Action: Run pinned revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e
Action->>Installer: Install Whitaker toolchain
Installer-->>Action: Provide verified Dylint driver
Action-->>CI: Installation succeeds
CI->>Lint: Run make lint
Lint-->>CI: Lint lane completes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved by concordat #331). That revision defaults whitaker-installer to 0.2.11, which builds the Dylint driver from a verified Clippy snapshot; upstream Dylint 6.0.1 clones Clippy's deletedmasterbranch, so every cold Whitaker driver build was failing and the lint lane was red.installer-version/WHITAKER_INSTALLER_VERSIONis set to0.2.11.Summary by Sourcery
Repin the CI Whitaker installation action to restore reliable Dylint linting.
Bug Fixes:
CI: