Repository navigation
Build(deps): Bump rust-toolchain from nightly-2026-04-25 to nightly-2026-10-23 - #357
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [rust-toolchain](https://github.com/rust-lang/rust) from nightly-2026-04-25 to nightly-2026-10-23. - [Release notes](https://github.com/rust-lang/rust/releases) - [Changelog](https://github.com/rust-lang/rust/blob/main/RELEASES.md) - [Commits](https://github.com/rust-lang/rust/commits) --- updated-dependencies: - dependency-name: rust-toolchain dependency-version: nightly-2026-10-23 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This was referenced Oct 23, 2026
Contributor
Author
|
Superseded by #362. |
auto-merge was automatically disabled
October 26, 2026 16:36
Pull request was closed
dependabot
Bot
deleted the
dependabot/rust_toolchain/rust-toolchain-nightly-2026-10-23
branch
October 26, 2026 16:36
leynos
added a commit
that referenced
this pull request
Oct 28, 2026
…358) (#360) * Pin the default PostgreSQL version to avoid dropped hard links Bootstrapping without `PG_VERSION_REQ` installed whatever release upstream listed as the newest match. From `18.6.1` onward the Linux and macOS archives pack most of `share/timezone` as tar hard links, and the `postgresql_archive` release this crate builds against extracts regular files, directories and symlinks but silently drops hard links. The resulting tree has no `share/timezone/UTC`, so every session that names a zone failed with `invalid value for parameter "TimeZone": "UTC"` (#351). `DEFAULT_VERSION_REQ` now names `=18.6.0`, which predates the switch and resolves zone names from the host zoneinfo database as before. `PG_VERSION_REQ` still overrides it. An installation directory holding several version subdirectories also has to resolve to one the settings' version requirement accepts, or a newer directory left behind by an earlier run would quietly undo an exact pin; `resolve_installed_dir` gained that filter. This is a hold, not the fix. `postgresql_archive` 0.22.0 extracts hard links and removes the need for the pin, but that release needs Rust 1.94, above this crate's currently declared minimum. Delete `DEFAULT_VERSION_REQ` when the dependency moves. `tests/timezone_regression.rs` proves the pin end to end: it starts one real cluster and asks the server to resolve three named zones, including two that are hard links to `UCT` in the affected archives. Co-Authored-By: Claude Code <noreply@anthropic.com> * Check the Whitaker pin against the approved list, not one SHA `tests/whitaker_install_pin.rs` asserted an exact commit for every `install-whitaker` reference. That turned each legitimate action release into a failing test, and the failure said only that the SHA differed, not whether the new one was a revision the concordat policy permits (#336). The test now asserts the shape the pin must have - 40 lowercase hex characters - and that the revision appears in a local list of the commits approved by concordat QG-002 (`whitaker-provisioning`). A well-formed but unlisted SHA fails, a truncated SHA fails even when its prefix is listed, and adding an approval is a deliberate edit with the rule reference beside it. The mutation check confirms the list is consulted rather than merely present. Co-Authored-By: Claude Code <noreply@anthropic.com> * Update dependencies and drop the deprecated parser `ok` call Bump the dev-dependency ceilings that Dependabot raised and the `makefile-lossless` release brings: `makefile-lossless` 0.4.8, `proptest` 1.12.0, `trybuild` 1.0.122, plus `serde_json` 1.0.154 and `sha2` 0.11.1. Every requirement stays a caret range, as the repository's dependency policy requires, and `Cargo.lock` follows. `makefile-lossless` 0.4.8 deprecates `Parse::ok` in favour of `is_ok` (#354). The guard in `tests/makefile_version_guard.rs` only ever asks whether the parse recovered, so `is_ok` says the same thing without the deprecation warning, and the comment records why the value was never wanted. Co-Authored-By: Claude Code <noreply@anthropic.com> * Bump the lint toolchain to nightly-2026-10-23 Move `rust-toolchain.toml` from `nightly-2026-04-25` to `nightly-2026-10-23` (#357) and fix every new lint rather than silencing it, as the repository's lint policy requires. `AtomicUsize::fetch_update` is deprecated in favour of `try_update`, but `try_update` is stable only from Rust 1.95, above this crate's declared minimum of 1.92. The privilege-drop counter therefore decrements through a hand-rolled `compare_exchange` loop, which gives the same guarantee on every supported toolchain instead of raising the MSRV for one call. The remaining lints are mechanical: a `#[deprecated]` item gains the `since` version the lint now requires, `ExtensionName` gains the `FromStr` implementation Clippy expects alongside the `TryFrom<&str>` it has to keep for compatibility, and three test helpers compare against an empty `Vec` instead of asserting `is_empty`, which the new `assert_is_empty` lint rejects. The five diesel test binaries lost nothing: an earlier draft put a file-scope `#[expect(clippy::redundant_field_names)]` in each, on the theory that the `QueryableByName` derive emits a redundant initialiser. It does not. `cargo clippy --workspace --all-targets --all-features` passes with no expectation and no report, and `make msrv` confirms the same at the declared 1.92, so the expectations were removed rather than kept as a blanket suppression the repository's lint policy forbids. The developers guide records why the `ui` tests run without the compile wrapper: their nested trybuild builds queue for an admission slot, and on a loaded host all six hit the package-cache lock together and time out. Co-Authored-By: Claude Code <noreply@anthropic.com> * Pin every shared action to one reviewed commit The `leynos/shared-actions` references named four different commits, so each workflow tracked a different snapshot of the same action repository. Move them all to `e693d81d`, the commit the coverage step already used, so one reviewed revision governs every use and a future bump is a single change. Co-Authored-By: Claude Code <noreply@anthropic.com> * Repair CI and retain Rust 1.92 (#358) Stage the privileged worker where dropped processes can execute it, correct unprivileged observability checks, and avoid Windows sccache command limits. Consolidate UI builds and give their shared admission queue a bounded budget consistent with the outer watchdog. Keep the declared Rust 1.92 floor and defer incompatible PostgreSQL dependency updates in Dependabot. Consolidate duplicated installation tests while preserving their version-selection cases. * Address review of dependency queue fixes (#358) Exercise the default PostgreSQL version and extension parsing directly, and verify installation selection against an independent property oracle. Make worker staging checks portable and cover source precedence. Document the public version behaviour and current CI settings, and move large test data and settings cases into focused files to respect the repository's file size limit. * Simplify review test scenarios (#358) Express worker precedence cases as named scenarios and separate the UI fixture's parsing and target checks. Preserve coverage while keeping the tests easy to read and clearing the reported code health findings. * Document internal setup contracts (#358) Explain version selection, cached worker discovery and concurrent guard counter updates for maintainers of the affected setup paths. * Clarify and verify version selection (#358) Exercise an unapproved workflow pin through the real validation path, correct version and timezone guidance, and keep the staging check portable. Add bounded diagnostics and tests for version and installation selection so operators can understand the selected behaviour. * Strengthen selection guidance and tests (#358) Illustrate installation selection accessibly and record its migration and design implications. Validate the actual workflow uses entry and exercise concurrent privilege-counter releases deterministically. Preserve diagnostic read errors and wait for the watcher to open its lock before checking inherited descriptors, avoiding a loader race. * Publish staged workers atomically (#358) Prepare worker and pointer files under unique temporary names before atomic publication. Replace truncated or incorrectly permissioned legacy copies and retain the full spawn error chain in test failures. Avoid overwriting an executable another test process may be using while preserving parallel test execution and existing staging protections. * Tighten installer input verification (#358) Validate the actual installer-version input and reject misleading comments or duplicate inputs. Consolidate freshness cases and correct the design document's original default-version statement. * Clarify fixture and worker guidance (#358) Align the design summary and dependency floor with the retained Rust 1.92 policy. Document atomic test-worker staging and its freshness and fallback limits for contributors. --------- Co-authored-by: leynos <leynos@rohga> Co-authored-by: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Cooldown could not be applied because no publication date was available from the registry.
Bumps rust-toolchain from nightly-2026-04-25 to nightly-2026-10-23.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)