Repository navigation
Repin install-whitaker to the 0.2.11 revision - #146
Conversation
Pin install-whitaker to shared-actions 5a99aed78ce68dcebd3052b75c31e6f173162b1e, which defaults the installer to 0.2.11 and builds the Dylint driver from a verified Clippy snapshot. Upstream Dylint 6.0.1 clones Clippy's deleted master branch, so every cold driver build failed. Any explicit installer-version is set to 0.2.11.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update the Whitaker action revision .github/workflows/ci.yml |
The Install Whitaker step uses the new shared-action revision. The cranelift: true input remains unchanged. |
Possibly related issues
leynos/whitaker#530— The issue covers adoption of the released Whitaker installer and bootstrap.leynos/whitaker#529— The issue covers the Clippy snapshot bootstrap used by the action revision.
Possibly related PRs
- leynos/corbusier#249 — Updates the same action to the same revision.
- leynos/agent-template-python#110 — Updates the same action revision and retains
cranelift: true. - leynos/netsuke#1042 — Updates the same action revision and its related workflow contract.
Suggested labels: Issue
Priority:
Change: Bug fix
Merge Risk: 
Minimal · previous review 4d2c5
-
The workflow pin is compatible with the existing Whitaker installation contract and is ready to merge.
Pre-merge checks: 
14
-
Full details: Testing (Overall)
-
Explanation
Pass the testing check. The pull request changes only the pinned revision of the third-party
install-whitakeraction in.github/workflows/ci.yml;cranelift: trueremains unchanged. The check does not require tests to prove that a third-party tool works as advertised. The existing workflow still runsmake lintafter installation, and the repository’s workflow contract tests remain in CI.
Full details: User-Facing Documentation
-
Explanation
Pass the documentation check. The pull request changes only the pinned revision of the CI
install-whitakeraction. It does not change application, API, CLI, or other user-facing behaviour, and the existingcraneliftinput remains unchanged. No update todocs/users-guide.mdis required.
Full details: Developer Documentation
-
Explanation
PASS — The pull request changes only the CI action revision for the existing Whitaker installation. It does not add or change an internal API, architectural boundary, abstraction, local build requirement, or developer-facing tool. The developer guide already documents that
make lintruns Whitaker, and the Makefile invocation is unchanged. No design, ADR, roadmap, or execplan update is required.
Full details: Module-Level Documentation
-
Explanation
The check is inapplicable. The pull request changes only the
Install Whitakeraction revision in.github/workflows/ci.yml; it adds or modifies no modules. No module-level documentation failure was introduced.
Full details: Testing (Unit And Behavioural)
-
Explanation
The pull request changes only one immutable GitHub Actions reference in
.github/workflows/ci.yml; it adds no application code or local behaviour. The existing CI boundary installs Whitaker and then runsmake lint, which exercises the pinned action in the workflow that it changes. No separate unit or end-to-end test is required for this pin-only change.
Full details: Testing (Property / Proof)
-
Explanation
PASS: The pull request changes one GitHub Actions revision in
.github/workflows/ci.ymland preservescranelift: true. It introduces no code invariant over inputs, states, orderings, or transitions, and it introduces no lemma or proof assumption. Property testing or exhaustive proof is therefore not applicable.
Full details: Testing (Compile-Time / Ui)
-
Explanation
Pass. The pull request changes only the pinned revision of the
install-whitakerGitHub Action. It introduces no Rust or TypeScript compile-time behaviour and no text-based or UI-adjacent output. No trybuild or snapshot test is required by this check.
Full details: Unit Architecture
-
Explanation
The pull request changes only
.github/workflows/ci.yml. It replaces one pinnedinstall-whitakeraction revision and keepscranelift: trueunchanged. It adds no query, command, fallible operation, dependency, state mutation, or test unit. The Unit Architecture conditions are therefore not triggered.
Full details: Domain Architecture
-
Explanation
The pull request changes only the GitHub Actions pin for
install-whitakerin.github/workflows/ci.yml. It does not change domain code, domain interfaces, commands, repositories, adapters, or business rules. The Domain Architecture failure conditions are not applicable.
Full details: Observability
-
Explanation
PASS: The pull request changes only the pinned revision of the
Install WhitakerGitHub Actions step. It does not change production code or introduce a production operational failure mode, throughput path, service boundary, or state transition that requires new logs, metrics, traces, or alerts. The workflow step remains an explicit failure boundary for CI diagnosis.
-
Pin the action to a newer track
Keep cranelift: true intact
CI follows the updated ref
Whitaker steps along the path
One small change in the workflow file
Comment @coderabbitai help to get the list of available commands.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the CI workflow’s pinned Whitaker installation action from the failing revision to the approved shared-actions commit, whose installer defaults to whitaker-installer 0.2.11 and avoids the deleted Clippy master branch. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Lock-only update of the crates named by RUSTSEC-2026-0385, RUSTSEC-2026-0387, RUSTSEC-2026-0346, RUSTSEC-2026-0347, RUSTSEC-2026-0348, RUSTSEC-2026-0349, RUSTSEC-2026-0382 and RUSTSEC-2026-0383 (ctutils, crypto-bigint, rustls, rustls-webpki, webpki-root-certs); RUSTSEC-2023-0071 (rsa) has no fixed release and stays in the existing ignore list so cargo audit passes again.
Part of DF12-89
Repins
leynos/shared-actions/.github/actions/install-whitakerto5a99aed78ce68dcebd3052b75c31e6f173162b1e(shared-actions #651, approved by concordat #331). That revision defaults whitaker-installer to 0.2.11, which builds the Dylint driver from a verified Clippy snapshot; upstream Dylint 6.0.1 clones Clippy's deletedmasterbranch, so every cold Whitaker driver build was failing and the lint lane was red.installer-version/WHITAKER_INSTALLER_VERSIONis set to0.2.11.Cargo.lockonly) for RUSTSEC-2026-0385, -0387, -0346 to -0349, -0382 and -0383 (ctutils, crypto-bigint, rustls, rustls-webpki, webpki-root-certs): thecargo auditstep was failing every PR here, and the lint lane cannot go green without this repin, so the two have to land together. RUSTSEC-2023-0071 (rsa) has no fixed release and stays in the existing ignore list.Summary by Sourcery
Repin Whitaker installation and refresh affected dependency locks so the lint and audit CI lanes can pass reliably.
Bug Fixes:
CI:
Chores: