[leynos]

Part of DF12-89

Repins leynos/shared-actions/.github/actions/install-whitaker to 5a99aed78ce68dcebd3052b75c31e6f173162b1e (shared-actions #651, approved as a root by concordat QG-002). The action then defaults to whitaker-installer 0.2.11, which builds the Dylint driver from a verified Clippy snapshot: upstream Dylint 6.0.1 clones Clippy's master, which no longer exists, so every cold Whitaker driver build fails.

Pin-only: the files changed are (.github/workflows/ci.yml ) and only the install-whitaker revision moves. The previous pin was not an approved QG-002 revision.

Other Whitaker paths

None found: no bare cargo dylint, cargo binstall whitaker, hand-rolled installer or explicit installer-version outside the action and the whitaker wrapper.

Notes

A cache-restored driver rebuilds once (about a minute); that is expected. Gate: CI green on the lint lane at the head, with the lint job's log read for Whitaker's diagnostics.

Summary by Sourcery

Repin the CI Whitaker installation action to restore reliable Dylint driver builds.

Bug Fixes:

• Update the Whitaker lint action to a revision that uses whitaker-installer 0.2.11 and restores reliable cold driver builds.

CI:

• Repin the CI workflow's Whitaker installation action to the approved shared-actions revision.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-31T01:01:58.470969Z We couldn’t complete this review. Comment @codex review to try again.	c242642	PR opened
🔒 Security Review	⚠️ Failed 2026-10-31T01:02:03.152000Z We couldn’t complete this review. Comment @codex security review to try again.	c242642	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[chatgpt-codex-connector]

The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins.

[sourcery-ai]

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 5 days and 20 hours by commenting @sourcery-ai review. Upgrade to get a review now.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the CI lint workflow’s Whitaker action pin from the previous unapproved revision to approved shared-actions commit 5a99aed7, thereby using whitaker-installer 0.2.11 and fixing cold driver builds that fail against upstream Dylint 6.0.1’s removed Clippy master reference.

File-Level Changes

Change	Details	Files
Repin the Whitaker installation action to an approved shared-actions revision that supplies whitaker-installer 0.2.11 and avoids the broken upstream Clippy reference.	Replace the unapproved action SHA with the approved QG-002 root revision. Allow the action’s default installer to build the Dylint driver from a verified Clippy snapshot.	.github/workflows/ci.yml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

• Last reviewed commit: c242642

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Team
• Run ID: e133931e-9f13-485f-b452-df55e57dfa1b

Commits

Reviewing files that changed from the base of the PR and between 9e5de50 and c242642.

Files selected for processing: 1

• .github/workflows/ci.yml

Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• leynos/shared-actions (auto-detected)

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.

Update the Whitaker installer revision in .github/workflows/ci.yml to 5a99aed78ce68dcebd3052b75c31e6f173162b1e. This revision defaults to whitaker-installer 0.2.11 and addresses cold driver builds that fail when Dylint tries to clone Clippy’s removed master branch.

The PR description does not report that the CI lint gate has passed. Review the lint job for Whitaker diagnostics before treating the change as verified.

Walkthrough

The CI workflow now references revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e of the Whitaker Dylint installer action, replacing the previous revision.

Changes

CI installer pin

Layer / File(s)	Summary
Update installer revision .github/workflows/ci.yml	The workflow now pins the Whitaker Dylint installer action to revision 5a99aed78ce68dcebd3052b75c31e6f173162b1e.

Possibly related PRs

• leynos/mpsc-log#114: Updates the same installer pin to the same revision in a separate repository.
• leynos/comenq#241: Updates the same installer pin to the same revision in a separate repository.
• leynos/rustxt#121: Updates the same installer pin to the same revision in a separate repository.

Suggested labels: Issue

Change: Bug fix

Merge Risk: Minimal · up to c2426

No actionable merge-blocking issue is identified in the reviewed change.

Pre-merge checks: 13 · 2

Failed checks: 2 warnings

Check name	Status	Explanation	Resolution
Title check		The title accurately describes the Whitaker action repin. However, the description identifies the related issue as DF12-89, and the title does not include that issue reference.	Add the referenced issue number to the title, for example: "Repin install-whitaker to 5a99aed7 (DF12-89; whitaker-installer 0.2.11)".
Developer Documentation		Document the changed CI tooling. The pull request changes .github/workflows/ci.yml:47 from the previous install-whitaker action revision to 5a99aed78ce68dcebd3052b75c31e6f173162b1e. No developer…	Update docs/developers-guide.md with the effective Whitaker CI tooling, including the pinned install-whitaker revision or installer version, the verified Clippy snapshot used for cold driver builds, and the expected one-time rebuild aft…

Passed checks: 13 passed

Check name	Status	Explanation
Description check		The description directly explains the Whitaker action repin, its cause, its intended fix, and the validation gate.
Docstring Coverage		No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Testing (Overall)		Accept the change without adding a new test. The pull request changes only the pinned revision of the external leynos/shared-actions install-whitaker action in .github/workflows/ci.yml; it adds …
User-Facing Documentation		Treat the change as internal CI maintenance, not user-facing functionality. The reviewed diff changes only the pinned install-whitaker action revision in .github/workflows/ci.yml; it changes no ap…
Module-Level Documentation		The pull request changes only .github/workflows/ci.yml. It changes one install-whitaker action revision and does not add or modify a module. Therefore, it introduces no module-level documentation …
Testing (Unit And Behavioural)		Accept this check. The PR changes one external action revision only in .github/workflows/ci.yml (lines 46–49); it adds no local behaviour that needs unit tests. The existing CI path exercises the in…
Testing (Property / Proof)		PASS — The pull request changes one GitHub Actions revision only. The diff updates the install-whitaker action pin in .github/workflows/ci.yml from 872f59f... to 5a99aed...; it introduces no i…
Testing (Compile-Time / Ui)		PASS. The pull request changes only the GitHub Actions reference in .github/workflows/ci.yml from one install-whitaker revision to another. It does not change Rust or TypeScript source, compile-ti…
Unit Architecture		PASS. The pull request changes one workflow dependency reference only: .github/workflows/ci.yml:47 replaces the pinned install-whitaker revision. It adds no query, command, application unit, depen…
Domain Architecture		The pull request changes only the Whitaker installer action revision in .github/workflows/ci.yml (line 47). It does not change domain code, domain boundaries, commands, repositories, adapters, or bu…
Observability		PASS — the pull request changes one pinned action reference only (.github/workflows/ci.yml:46-49). The workflow keeps the named Whitaker install step and does not suppress its stdout, stderr, annota…

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Testing (Overall)

Explanation

Accept the change without adding a new test. The pull request changes only the pinned revision of the external leynos/shared-actions install-whitaker action in .github/workflows/ci.yml; it adds no repository functionality or local implementation logic. The workflow already runs make lint after the installation step. The check expressly does not require tests to verify that a third-party tool works as advertised.

Full details: User-Facing Documentation

Explanation

Treat the change as internal CI maintenance, not user-facing functionality. The reviewed diff changes only the pinned install-whitaker action revision in .github/workflows/ci.yml; it changes no application, library, CLI, or user-guide behaviour. Require no update to docs/users-guide.md, README signposting, or migration documentation.

Full details: Module-Level Documentation

Explanation

The pull request changes only .github/workflows/ci.yml. It changes one install-whitaker action revision and does not add or modify a module. Therefore, it introduces no module-level documentation failure.

Full details: Testing (Unit And Behavioural)

Explanation

Accept this check. The PR changes one external action revision only in .github/workflows/ci.yml (lines 46–49); it adds no local behaviour that needs unit tests. The existing CI path exercises the integration boundary by installing Whitaker and then running make lint. The same job also runs make test and make test-workflow-contracts (lines 48–56). The change does not introduce a missing test path or a disguised unit test.

Full details: Testing (Property / Proof)

Explanation

PASS — The pull request changes one GitHub Actions revision only. The diff updates the install-whitaker action pin in .github/workflows/ci.yml from 872f59f... to 5a99aed...; it introduces no invariant over inputs, states, orderings or transitions, and introduces no lemma or proof assumption. A property test or exhaustive proof is therefore not applicable.

Full details: Testing (Compile-Time / Ui)

Explanation

PASS. The pull request changes only the GitHub Actions reference in .github/workflows/ci.yml from one install-whitaker revision to another. It does not change Rust or TypeScript source, compile-time APIs, or text/UI output. The existing CI still runs make lint and make test at .github/workflows/ci.yml:46-56; therefore, this change does not require a trybuild-equivalent or snapshot test under this check.

Full details: Unit Architecture

Explanation

PASS. The pull request changes one workflow dependency reference only: .github/workflows/ci.yml:47 replaces the pinned install-whitaker revision. It adds no query, command, application unit, dependency interface, state access, or test code. The workflow keeps the action dependency explicit and pinned, and the subsequent lint command remains separate at .github/workflows/ci.yml:48-49. No Unit Architecture failure condition is introduced.

Full details: Domain Architecture

Explanation

The pull request changes only the Whitaker installer action revision in .github/workflows/ci.yml (line 47). It does not change domain code, domain boundaries, commands, repositories, adapters, or business rules. The Domain Architecture failure conditions are not introduced.

Full details: Observability

Explanation

PASS — the pull request changes one pinned action reference only (.github/workflows/ci.yml:46-49). The workflow keeps the named Whitaker install step and does not suppress its stdout, stderr, annotations, or job summary. The linked install-whitaker action records bounded cache, transfer, suite-source, result, and bootstrap context, and emits explicit errors at resolution, installation, and execution failures (shared-actions commit 872f59f53717b5bebe8e24b2f4a7496b089a939a, .github/actions/install-whitaker/action.yml:230-294, 920-1024; README:15-59). The change affects CI tooling, not a production service, so no new production metrics, traces, or alerts are required.

Full details: Developer Documentation

Explanation

Document the changed CI tooling. The pull request changes .github/workflows/ci.yml:47 from the previous install-whitaker action revision to 5a99aed78ce68dcebd3052b75c31e6f173162b1e. No developer documentation changes are included. docs/developers-guide.md:500-511 documents the Whitaker invocation and its LLVM requirements, but it does not document the installer revision or the changed cold-driver bootstrap behaviour.

Resolution

Update docs/developers-guide.md with the effective Whitaker CI tooling, including the pinned install-whitaker revision or installer version, the verified Clippy snapshot used for cold driver builds, and the expected one-time rebuild after cache restoration. State that no ADR is needed unless the change is intended to alter the system design.

_{Pin the installer to its new SHA,
Let the workflow follow that way.
Keep the revision clear and bright,
Let CI read the pin just right.
Send the old commit on its way.}

_{Comment @coderabbitai help to get the list of available commands.}